From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TLxGR-0000JD-8Q for openembedded-core@lists.openembedded.org; Wed, 10 Oct 2012 16:27:59 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q9AEEmq1021874; Wed, 10 Oct 2012 15:14:48 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 21462-05; Wed, 10 Oct 2012 15:14:44 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q9AEEdrG021868 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 10 Oct 2012 15:14:40 +0100 Message-ID: <1349878484.15658.220.camel@ted> From: Richard Purdie To: tom.zanussi@intel.com Date: Wed, 10 Oct 2012 15:14:44 +0100 In-Reply-To: References: X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 0/2] perl: fix @INC, v2 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2012 14:27:59 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2012-10-09 at 19:48 -0500, tom.zanussi@intel.com wrote: > From: Tom Zanussi > > This fixes the bug reported by Kang Kai in a way that allows > perf scripting to continue to work. > > Before this patch, @INC on the target would contain a native path: > > @INC: > /etc/perl > /usr/lib/perl/site_perl/5.14.2/ > /usr/lib/perl/site_perl/5.14.2 > /usr/lib/perl/vendor_perl/5.14.2/ > /usr/lib/perl/vendor_perl/5.14.2 > /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/ > /usr/lib/perl/5.14.2 > /usr/local/lib/site_perl > /usr/lib/perl/5.14.2 > . > > Kang Kai's patch reverted the problem that caused the native path > to appear, but also caused perf to report that scripting wasn't > supported. > > With this patchset, the native path is gone: > > Built under linux > Compiled at Oct 9 2012 18:40:15 > @INC: > /etc/perl > /usr/lib/perl/site_perl/5.14.2/ > /usr/lib/perl/site_perl/5.14.2 > /usr/lib/perl/vendor_perl/5.14.2/ > /usr/lib/perl/vendor_perl/5.14.2 > /usr/lib/perl/5.14.2/ > /usr/lib/perl/5.14.2 > /usr/local/lib/site_perl > /usr/lib/perl/5.14.2 > . > > and the perf Perl binding continues to work: > > root@crownbay:~# perf script rwtop > > read counts by pid: > > pid comm # reads bytes_req bytes_read > ------ -------------------- ---------- ---------- ---------- > 1524 perf 5629 213712 213648 > 1508 dropbear 8 131000 607 > > write counts by pid: > > pid comm # writes bytes_written > ------ -------------------- ---------- ------------- > 1522 perf 11 845320 > 1508 dropbear 8 944 > > Tested on qemux86 and crownbay. > > The following changes since commit 2c3e8280e67721d42d4be48a8e2c1e9ce9bb89fd: > > bitbake: hob/imageconfigurationpage: a 'hob-image' appears listed in the base image combo box (2012-10-08 16:23:34 +0100) > > are available in the git repository at: > > git://git.yoctoproject.org/poky-contrib.git tzanussi/bug-3099-fix > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/bug-3099-fix > > Tom Zanussi (2): > perl: add archlib_exp variable used to generate ARCHLIB_EXP in > config.h > perl: use archlib_exp config.sh variable I've taken these but I didn't like them being two commits, or the lack of information in the patch header. I therefore tweaked it before applying. Cheers, Richard