From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TQGca-0007Oh-U0 for openembedded-core@lists.openembedded.org; Mon, 22 Oct 2012 13:56:41 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q9MBh0vF004484; Mon, 22 Oct 2012 12:43:00 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 02633-10; Mon, 22 Oct 2012 12:42:56 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q9MBgpFY004478 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 22 Oct 2012 12:42:52 +0100 Message-ID: <1350906171.2520.82.camel@ted> From: Richard Purdie To: Martin Jansa Date: Mon, 22 Oct 2012 12:42:51 +0100 In-Reply-To: <20121022110809.GF3269@jama.jama.net> References: <1350658135.2520.29.camel@ted> <20121022104442.GD3269@jama.jama.net> <1350903508.2520.77.camel@ted> <20121022110809.GF3269@jama.jama.net> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Cc: openembedded-core Subject: Re: [PATCH] sstate: Improve handling of machine specific manifests X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 11:56:41 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2012-10-22 at 13:08 +0200, Martin Jansa wrote: > On Mon, Oct 22, 2012 at 11:58:28AM +0100, Richard Purdie wrote: > > On Mon, 2012-10-22 at 12:44 +0200, Martin Jansa wrote: > > > On Fri, Oct 19, 2012 at 03:48:55PM +0100, Richard Purdie wrote: > > > > Now do_package isn't machine specific, we're only left with do_populate_sysroot as a > > > > machine specific task. This change marks only the machine specific manifests as machine > > > > specific, defaulting to PACKAGE_ARCH for everything else. > > > > > > > > This means we do less work where there are multiple machines using the same > > > > core package architecture and we can start to clean up the sstate duplicate files > > > > whitelist. > > > > > > > > Signed-off-by: Richard Purdie > > > > --- > > > > diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass > > > > index d2a120b..dee84bf 100644 > > > > --- a/meta/classes/sstate.bbclass > > > > +++ b/meta/classes/sstate.bbclass > > > > @@ -17,10 +17,7 @@ SSTATE_EXTRAPATH = "" > > > > SSTATE_EXTRAPATHWILDCARD = "" > > > > SSTATE_PATHSPEC = "${SSTATE_DIR}/${SSTATE_EXTRAPATHWILDCARD}*/${SSTATE_PKGSPEC}" > > > > > > > > -# In theory we should be using: > > > > -# SSTATE_DUPWHITELIST = "${DEPLOY_DIR_IMAGE}/ ${DEPLOY_DIR}/licenses/ ${DEPLOY_DIR_IPK}/all/ ${DEPLOY_DIR_RPM}/all ${DEPLOY_DIR_DEB}/all/ ${TMPDIR}/pkgdata/all${TARGET_VENDOR}-${TARGET_OS}" > > > > -# However until do_package is not machine specific, we'll have to make do with all of deploy/pkgdata. > > > > -SSTATE_DUPWHITELIST = "${DEPLOY_DIR}/ ${TMPDIR}/pkgdata/" > > > > +SSTATE_DUPWHITELIST = "${DEPLOY_DIR_IMAGE}/ ${DEPLOY_DIR}/licenses/" > > > > > > Looks like warnings are back :/ > > > > > > WARNING: The recipe attr is trying to install files into a shared area when those files already exist. Those files are: > > > /OE/jansa-test/shr-core/tmp-eglibc/deploy/ipk/armv7a-vfp-neon/attr-locale-de_2.4.46-r4_armv7a-vfp-neon.ipk > > > /OE/jansa-test/shr-core/tmp-eglibc/deploy/ipk/armv7a-vfp-neon/attr-dbg_2.4.46-r4_armv7a-vfp-neon.ipk > > > /OE/jansa-test/shr-core/tmp-eglibc/deploy/ipk/armv7a-vfp-neon/attr-locale-sv_2.4.46-r4_armv7a-vfp-neon.ipk > > > ... > > > > > > and new warnings from pkgdata > > > WARNING: The recipe bison is trying to install files into a shared area when those files already exist. Those files are: > > > /OE/jansa-test/shr-core/tmp-eglibc/pkgdata/armv7a-vfp-neon-oe-linux-gnueabi/bison > > > /OE/jansa-test/shr-core/tmp-eglibc/pkgdata/armv7a-vfp-neon-oe-linux-gnueabi/runtime/bison-locale-nl.packaged > > > /OE/jansa-test/shr-core/tmp-eglibc/pkgdata/armv7a-vfp-neon-oe-linux-gnueabi/runtime/bison-dbg.packaged > > > /OE/jansa-test/shr-core/tmp-eglibc/pkgdata/armv7a-vfp-neon-oe-linux-gnueabi/runtime/bison-doc > > > /OE/jansa-test/shr-core/tmp-eglibc/pkgdata/armv7a-vfp-neon-oe-linux-gnueabi/runtime/bison-locale-th.packaged > > > ... > > > > The question is why as they shouldn't be, these changes were meant to > > fix this properly. Initially I wondered if this was another > > manifestation of https://bugzilla.yoctoproject.org/show_bug.cgi?id=3219 > > but I'm not so sure. > > Probably not as this happens on builder with 2 machines using the same > tune and the same CCARGS. > > > Can you figure out which two recipes are trying to install these sets of > > files? > > I'll try to compare them with scripts/sstate-diff.sh again to see if > checksums are the same between those 2 machines, but those warnings are > shown already when building 1 machine. > > > Or perhaps this is a one off transition issue I didn't see here when > > testing this? Does a build from a clean tmp do this? > > Yes I've removed tmp-eglibc before starting this build (kept only > sstate-cache) and it's building first machine. If the warnings are showing up even after building one machine, there is something very strange going on. Did it run the setscene do_package task for these recipes? Its as if it installed from sstate and then decided to overwrite the files. Something isn't making sense though :/. Firstly, the sstate should have been invalidated due to the package class and variable changes. Secondly, if it had installed the files, it should be uninstalled them before installing a second set. So I'm confused as to what is going on here... Cheers, Richard