From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Giuseppe CONDORELLI <giuseppe.condorelli@st.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] base-files: do_install_basefilesissue error
Date: Tue, 23 Oct 2012 09:57:43 +0100 [thread overview]
Message-ID: <1350982663.22340.23.camel@ted> (raw)
In-Reply-To: <1350974753-519-1-git-send-email-giuseppe.condorelli@st.com>
On Tue, 2012-10-23 at 08:45 +0200, Giuseppe CONDORELLI wrote:
> Fixed error in do_install_basefilesissue, printf is now replaced by echo.
What kind of error?
Doesn't this change have issues about how newlines are handled?
Cheers,
Richard
> Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> ---
> meta/recipes-core/base-files/base-files_3.0.14.bb | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index ba355ee..766b0e5 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -117,11 +117,11 @@ do_install_basefilesissue () {
>
> install -m 644 ${WORKDIR}/issue* ${D}${sysconfdir}
> if [ -n "${DISTRO_NAME}" ]; then
> - printf "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue
> - printf "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue.net
> + echo "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue
> + echo "${DISTRO_NAME} " >> ${D}${sysconfdir}/issue.net
> if [ -n "${DISTRO_VERSION}" ]; then
> - printf "${DISTRO_VERSION} " >> ${D}${sysconfdir}/issue
> - printf "${DISTRO_VERSION} " >> ${D}${sysconfdir}/issue.net
> + echo "${DISTRO_VERSION} " >> ${D}${sysconfdir}/issue
> + echo "${DISTRO_VERSION} " >> ${D}${sysconfdir}/issue.net
> fi
> echo "\n \l" >> ${D}${sysconfdir}/issue
> echo >> ${D}${sysconfdir}/issue
next prev parent reply other threads:[~2012-10-23 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 6:45 [PATCH] base-files: do_install_basefilesissue error Giuseppe CONDORELLI
2012-10-23 8:57 ` Richard Purdie [this message]
2012-10-23 9:00 ` Giuseppe Condorelli
-- strict thread matches above, loose matches on Subject: below --
2012-10-22 15:32 Giuseppe CONDORELLI
2012-10-23 1:40 ` Chris Larson
2012-10-23 7:54 ` Martin Jansa
2012-10-23 7:56 ` Giuseppe Condorelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350982663.22340.23.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=giuseppe.condorelli@st.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox