From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TX89d-0008Pv-W2 for openembedded-core@lists.openembedded.org; Sat, 10 Nov 2012 11:19:10 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id qAAA5HmR030334; Sat, 10 Nov 2012 10:05:17 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 22363-06; Sat, 10 Nov 2012 10:05:12 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id qAAA56vM030328 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sat, 10 Nov 2012 10:05:07 GMT Message-ID: <1352541905.9083.27.camel@ted> From: Richard Purdie To: Otavio Salvador Date: Sat, 10 Nov 2012 10:05:05 +0000 In-Reply-To: References: <154a30032b03a9ce269752adbf5bbec85205720e.1352455397.git.ross.burton@intel.com> <1352501827.9083.21.camel@ted> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 2/2] meta: remove redundant _FOR_BUILD variables X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2012 10:19:10 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2012-11-09 at 21:23 -0200, Otavio Salvador wrote: > On Fri, Nov 9, 2012 at 8:57 PM, Richard Purdie > wrote: > On Fri, 2012-11-09 at 20:32 -0200, Otavio Salvador wrote: > > On Fri, Nov 9, 2012 at 8:09 AM, Ross Burton > > > wrote: > > Signed-off-by: Ross Burton > > > > Please bump PR. Even it might not change the end result we > need to > > force a rebuild as we did change the meta-data and we risk > having a > > subtle bug somewhere. > > This patch set adds a number of exports to autotools.bbclass. > In doing > so, the sstate checksums will change for pretty much > everything and > hence pretty much everything will rebuild. Using PR > specifically to > force a rebuild is therefore unnecessary. > > If it rebuilds it might get a different binary package and for > preserve the upgrade path PR bumps are need, aren't they? Technically you are correct (I took your comment above to refer to rebuilding the recipes). Technically we should bump PR for every recipe using the autotools class. We don't however bump PR of every recipe every time we change the core classes and there is plenty of precedent for not doing that. This is basically why I think the whole "PR bump" thing is flawed and we should stop doing it in favour of some automated mechanism like PR service. This is why its high on the 1.4 feature list since I've had enough of this madness. I'm not going to ask Ross to spend the hour it would take to manually bump PR for each recipe using autotools and even that won't account for PR in other layers. Cheers, Richard