From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TYdGf-0003Kq-3q for openembedded-core@lists.openembedded.org; Wed, 14 Nov 2012 14:44:37 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id qAEDUe6X020143; Wed, 14 Nov 2012 13:30:40 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 19887-02; Wed, 14 Nov 2012 13:30:36 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id qAEDUWPu020137 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 14 Nov 2012 13:30:33 GMT Message-ID: <1352899832.13332.7.camel@ted> From: Richard Purdie To: Martin Jansa Date: Wed, 14 Nov 2012 13:30:32 +0000 In-Reply-To: <1352899442.13332.2.camel@ted> References: <1352815159.24487.122.camel@ted> <20121114123026.GK3928@jama.jama.net> <1352899442.13332.2.camel@ted> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Cc: Michael, openembedded-core Subject: Re: [PATCH] bash: Add fix for cross compile issues X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2012 13:44:37 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2012-11-14 at 13:24 +0000, Richard Purdie wrote: > On Wed, 2012-11-14 at 13:30 +0100, Martin Jansa wrote: > > On Tue, Nov 13, 2012 at 01:59:19PM +0000, Richard Purdie wrote: > > > Signed-off-by: Richard Purdie > > > --- > > > diff --git a/meta/recipes-extended/bash/bash-4.2/crossfix.patch b/meta/recipes-extended/bash/bash-4.2/crossfix.patch > > > new file mode 100644 > > > index 0000000..f587c34 > > > --- a/dev/null > > > +++ b/meta/recipes-extended/bash/bash-4.2/crossfix.patch > > > @@ -0,0 +1,28 @@ > > > > Are you using some special tool to generate git patches or some weird > > git version? > > Basically, the data from cgit in the web interface is broken and that is > causing this. > > > Patches from you where you add some file usually does not apply here, > > It's caused by: > > --- a/dev/null > > +++ b/meta/recipes-extended/bash/bash-4.2/crossfix.patch > > which usually looks like > > --- /dev/null > > +++ b/meta/recipes-extended/bash/bash-4.2/crossfix.patch > > Right, there is a bug in cgit. I'm not sure if anyone fancies trying to > find/fix it? Actually, its not hard to find: http://hjemli.net/git/cgit/tree/ui-patch.c In header(), the: htmlf("\n--- a/%s\n", path1); htmlf("+++ b/%s\n", path2); needs to be conditional on is_null_sha1(sha1)/is_null_sha1(sha2) with the alternative of: htmlf("\n--- /%s\n", path1); htmlf("+++ /%s\n", path2); which there are a variety of ways to achieve... Michael: Fancy fixing that on the server and sending a patch upstream? :) Cheers, Richard