Re: [PATCH 12/12] xf86-video-omapfb: upgrade to 0.4.2

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2012-11-21 at 10:48 +0100, Martin Jansa wrote:
> On Tue, Nov 13, 2012 at 03:11:34PM +0100, Denis 'GNUtoo' Carikli wrote:
> > On Tue, 13 Nov 2012 14:18:29 +0200
> > Laurentiu Palcu <laurentiu.palcu@intel.com> wrote:
> > 
> > > Other changes:
> > >  * changed the recipe's SRC_URI to track the new (maintained) repo;
> > >  * removed all old patches as the latest driver's structure has
> > > changed drastically;
> > >  * license file changed quite a bit: MIT -> GPLv2 (needs to be
> > > reviewed by somebody with a better understanding of these things
> > > though);
> > >  * xf86-video-omapfb changed its name to xf86-video-omap: change the
> > >    recipe name and config files accordingly;
> > >  * add dependency of libdrm-omap;
> > > 
> > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> > > ---
> > >  meta-yocto-bsp/conf/machine/beagleboard.conf       |    2 +-
> > >  ...-video-omapfb_git.bb => xf86-video-omap_git.bb} |   23
> > > ++++++++------------ .../target/arch/arm/conf/machine/{{=machine}}.conf
> > > |    2 +- 3 files changed, 11 insertions(+), 16 deletions(-)
> > >  rename meta/recipes-graphics/xorg-driver/{xf86-video-omapfb_git.bb
> > > => xf86-video-omap_git.bb} (43%)
> > > 
> > > diff --git a/meta-yocto-bsp/conf/machine/beagleboard.conf
> > > b/meta-yocto-bsp/conf/machine/beagleboard.conf index 6633880..204be95
> > > 100644 --- a/meta-yocto-bsp/conf/machine/beagleboard.conf
> > > +++ b/meta-yocto-bsp/conf/machine/beagleboard.conf
> > > @@ -6,7 +6,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg"
> > >  XSERVER ?= "xserver-xorg \
> > >             xf86-input-evdev \
> > >             xf86-input-mouse \
> > > -           xf86-video-omapfb \
> > > +           xf86-video-omap \
> > >             xf86-input-keyboard"
> > Since xf86-video-omap is a totally different driver and depend on:
> > * omap DRM video driver that is in staging only in recent kernels.
> > * enabling the omap DRM in the board file(providing you don't use
> >   device tree), which is not straingtforward(there are tricks required).
> > * omap enabled in libdrm.
> > 
> > Could you instead make a new xf86-video-omap recipe instead of
> > modifying the xf86-video-omapfb one?
> 
> Btw xf86-video-omapfb does not support xserver-1.13 video API.
> 
> Someone needs to port
> http://cgit.freedesktop.org/xorg/driver/xf86-video-omap/commit/?id=0615ee8cd73068332879695cbdf662cf5b9b597c
> to xf86-video-omapfb or merge missing functionality from omapfb to omap
> driver.
> 
> I've similar patch to fix xf86-video-glamo in meta-oe, but cannot test
> it in runtime until we fix SIGILL in systemd dbus on armv4t
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2012-November/042298.html

Watching things starting to break on the autobuilder due to this is
extremely depressing/frustrating, not least as once you start to see
bits of red which are "known", you start to ignore that build entry all
the time and start missing other bugs.

We really need to have a zero tolerance of build breakage like this,
particularly when there is nobody stepping up and saying "I will fix
this in X timeframe". 

Based on that I've removed the omapfb driver. If someone steps up and
fixes it, I don't mind it coming back but until then, I don't want the
build failures, or to confuse users with recipes that don't work.

Cheers,

Richard