From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.pbcl.net ([88.198.119.4] helo=hetzner.pbcl.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Tbq9b-0006i2-Vq for openembedded-core@lists.openembedded.org; Fri, 23 Nov 2012 11:06:36 +0100 Received: from elite.brightsigndigital.co.uk ([81.142.160.137] helo=[172.30.1.145]) by hetzner.pbcl.net with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1Tbpvy-0005G5-EB; Fri, 23 Nov 2012 10:52:30 +0100 From: Phil Blundell To: Martin Jansa Date: Fri, 23 Nov 2012 09:52:28 +0000 In-Reply-To: <1353661767-13873-1-git-send-email-Martin.Jansa@gmail.com> References: <1353661767-13873-1-git-send-email-Martin.Jansa@gmail.com> X-Mailer: Evolution 3.0.2- Message-ID: <1353664350.13864.701.camel@phil-desktop> Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [RFC][PATCH] arch-armv4.inc: add --fix-v4bx to TARGET_LD_KERNEL_ARCH only for armv4 and strongarm1100 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2012 10:06:36 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2012-11-23 at 10:09 +0100, Martin Jansa wrote: > -TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("TUNE_FEATURES", "armv4", "--fix-v4bx", "", d)}" > +TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("DEFAULTTUNE", "armv4", "--fix-v4bx", "", d)}" Testing DEFAULTTUNE doesn't really seem like the right thing. Not that I am any expert in the twisty maze of tune variables, but I would have thought this should be: TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("TUNE_FEATURES", "thumb", "", "--fix-v4bx", d)}" Or maybe it could just be fixed in the kernel, since its own build system already knows whether Thumb is available or not. p.