From: Phil Blundell <philb@gnu.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC][PATCH] arch-armv4.inc: add --fix-v4bx to TARGET_LD_KERNEL_ARCH only for armv4 and strongarm1100
Date: Fri, 23 Nov 2012 10:48:36 +0000 [thread overview]
Message-ID: <1353667731.13864.723.camel@phil-desktop> (raw)
In-Reply-To: <20121123102258.GJ12637@jama.jama.net>
On Fri, 2012-11-23 at 11:22 +0100, Martin Jansa wrote:
> On Fri, Nov 23, 2012 at 09:52:28AM +0000, Phil Blundell wrote:
> > On Fri, 2012-11-23 at 10:09 +0100, Martin Jansa wrote:
> > > -TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("TUNE_FEATURES", "armv4", "--fix-v4bx", "", d)}"
> > > +TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("DEFAULTTUNE", "armv4", "--fix-v4bx", "", d)}"
> >
> > Testing DEFAULTTUNE doesn't really seem like the right thing. Not that
> > I am any expert in the twisty maze of tune variables, but I would have
> > thought this should be:
> >
> > TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("TUNE_FEATURES", "thumb", "", "--fix-v4bx", d)}"
>
> Depends if we want to apply it on e.g. armv5te device without thumb in
> TUNE_FEATURES.
Oh, yes, right. Well, if you aren't using thumb then --fix-v4bx is
going to be mostly harmless, but I suppose the correct thing would be to
check for TUNE_FEATURES containing neither thumb nor armv5.
p.
prev parent reply other threads:[~2012-11-23 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 9:09 [RFC][PATCH] arch-armv4.inc: add --fix-v4bx to TARGET_LD_KERNEL_ARCH only for armv4 and strongarm1100 Martin Jansa
2012-11-23 9:52 ` Phil Blundell
2012-11-23 10:22 ` Martin Jansa
2012-11-23 10:48 ` Phil Blundell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353667731.13864.723.camel@phil-desktop \
--to=philb@gnu.org \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox