From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TcwzF-0001ug-Ir for openembedded-core@lists.openembedded.org; Mon, 26 Nov 2012 12:36:29 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id qAQBMISu022230; Mon, 26 Nov 2012 11:22:18 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 19621-04; Mon, 26 Nov 2012 11:22:13 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id qAQBMA7U022223 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 26 Nov 2012 11:22:11 GMT Message-ID: <1353928930.21863.57.camel@ted> From: Richard Purdie To: Otavio Salvador Date: Mon, 26 Nov 2012 11:22:10 +0000 In-Reply-To: References: <1353874980.21863.20.camel@ted> <1353928626.21863.56.camel@ted> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Cc: openembedded-core Subject: Re: [PATCH] allarch: Allow class to be included but overridden X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 11:36:29 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2012-11-26 at 09:19 -0200, Otavio Salvador wrote: > On Mon, Nov 26, 2012 at 9:17 AM, Richard Purdie > wrote: > > On Mon, 2012-11-26 at 09:08 -0200, Otavio Salvador wrote: > >> On Sun, Nov 25, 2012 at 6:23 PM, Richard Purdie > >> wrote: > >> > We have cases where we'd like to inherit this class by default but allow > >> > special cases to override it. This change makes the code of the class > >> > conditional on PACKAGE_ARCH remaining set to "all", allowing it to be > >> > overridden. packagegroup usage is one case this is desirable. > >> > > >> > Signed-off-by: Richard Purdie > >> > --- > >> > >> Richard, I fail to see the usecase of packagroup. Can you clarify? > > > > packagegroup.bbclass previously set PACKAGE_ARCH = "all" which was > > confusing other code. Anything using the all package arch should really > > use allarch so we are consistent about how we set the various variables. > > > > Even though packagegroup.bbclass now uses allarch, we need specific > > packagegroup packages to be able to override the class e.g. marking > > themselves machine specific. This is why we need to make this change. > > My only concern is if we could make allarch to raise an exception if > you inherit it and set package arch to another value? We're deciding that we're supporting that exact usecase though? > The only bad effect about it is we won't be able to change something > in a bbappend which makes the package arch specific that way. Why not? This should be perfectly usable from a .bbappend? Cheers, Richard