Re: [PATCH] gst-meta-base: Make ximagesing optional on x11 DISTRO_FEATURE

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2012-11-25 at 22:15 -0800, Saul Wold wrote:
> If x11 is disabled from DISTRO_FEATURE we don't build the ximagesink
> package, but it still becomes a dependency in the final image which
> causes a failure
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  .../gstreamer/gst-meta-base_0.10.bb                |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> index 2fb39d5..0889437 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> @@ -16,7 +16,10 @@ PACKAGES = "\
>  
>  ALLOW_EMPTY = "1"
>  
> +X11_RDEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', 'gst-plugin-base-ximagesink', '', d)}"
> +
>  RDEPENDS_gst-meta-base = "\
> +    ${X11_RDEPENDS} \
>      gstreamer \
>      gst-plugins-base-playbin \
>      gst-plugins-base-decodebin \

This doesn't make sense, surely there would be some removal of a
dependency as well as an addition?

Looking at the recipe, the ximagesink dependency is already dependent on
DISTRO_FEATURES and is in the gst-meta-x11-base package, not
gst-meta-base?

Cheers,

Richard