Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] apt-native: fix the creation of apt.conf.sample
Date: Tue, 08 Jan 2013 10:47:11 +0000	[thread overview]
Message-ID: <1357642031.13022.1.camel@ted> (raw)
In-Reply-To: <b26787f62090d0760758b854627e94de25d6ccca.1357640488.git.hongxu.jia@windriver.com>

On Tue, 2013-01-08 at 18:23 +0800, Hongxu Jia wrote:
> The file of apt.conf.sample is kept in outdir, and outdir is assigned
> by "os.path.join" with the params of ${D}, ${sysconfdir} and "apt". But
> ${sysconfdir} is an absolute dir and that is not allowed by "os.path.join".
> 
> The following is the help on function os.path.join(a, *p):
>      Join two or more pathname components, inserting '/' as needed.
>      If any component is an absolute path, all previous path components
>      will be discarded.
> 
> So remove "/" in ${sysconfdir} to create "apt.conf.sample" if it doesn't
> exist, not by the existance of prefix dir.

Use oe.path.join() instead which doesn't have this problem iirc.

Cheers,

Richard




  reply	other threads:[~2013-01-08 11:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 10:23 [PATCH 0/1] apt-native: fix the creation of apt.conf.sample Hongxu Jia
2013-01-08 10:23 ` [PATCH 1/1] " Hongxu Jia
2013-01-08 10:47   ` Richard Purdie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-01-10  7:58 [PATCH 0/1] " Hongxu Jia
2013-01-10  7:58 ` [PATCH 1/1] " Hongxu Jia
2013-01-06  8:43 [PATCH 0/1] " Hongxu Jia
2013-01-06  8:43 ` [PATCH 1/1] " Hongxu Jia
2013-01-07 21:36   ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357642031.13022.1.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox