Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: image_types.bbclass: what's with "elf" and "cpio.gz"?
Date: Sat, 12 Jan 2013 13:05:30 +0000	[thread overview]
Message-ID: <1357995930.4072.134.camel@ted> (raw)
In-Reply-To: <alpine.DEB.2.02.1301120618220.15410@oneiric>

On Sat, 2013-01-12 at 06:22 -0500, Robert P. J. Day wrote:
> this snippet from image_types.bbclass:
> 
>     if "elf" in alltypes:
>         alltypes.remove("elf")
>         if "cpio.gz" not in alltypes:
>                 alltypes.append("cpio.gz")
>         alltypes.append("elf")
> 
>     # Filter out all the compressed images from types
>     for type in alltypes:
>     ... snip ...
> 
> i was going to trivially fix that comment (it's now "alltypes", not
> "types"), but i was distracted by the code above that -- what the heck
> is going on there?  what's the rationale for removing elf, then adding
> cpio.gz and elf back on at the end?  if someone can clarify that, i
> can add that as more comment, as well as a few other tweaks in that
> file for more documentation for anyone reading TFS.  thanks.

Order is important. The elf image depends on the cpio.gz image already
having been created so a) it must be created and b) it must happen
before elf.

Cheers,

Richard






  reply	other threads:[~2013-01-12 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-12 11:22 image_types.bbclass: what's with "elf" and "cpio.gz"? Robert P. J. Day
2013-01-12 13:05 ` Richard Purdie [this message]
2013-01-12 19:15   ` Chris Larson
2013-01-13 10:14     ` Robert P. J. Day
2013-01-13 12:32     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357995930.4072.134.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox