public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: "Andreas Müller" <schnitzeltony@googlemail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] systemd.bbclass: Introduce do_install_append and use systemd unitdir
Date: Wed, 13 Feb 2013 17:52:05 +0000	[thread overview]
Message-ID: <1360777925.4246.86.camel@phil-desktop.brightsign> (raw)
In-Reply-To: <CALbNGRSiit5QwsYsrAbWhGQUzgCYYjScUdZPuoBxCDRDgOKbgQ@mail.gmail.com>

On Wed, 2013-02-13 at 00:55 +0100, Andreas Müller wrote:
> Copying similar code in in tons of recipes is easier to maintain?

If the code that needs to go in the "tons" of recipes is just:

do_install_append() {
	install -m 644 ${WORKDIR}/my.service ${D}${systemd_unitdir}/system
}

then yes, this is easier to maintain than a mechanism that magically
fishes out files from the workdir and installs them for itself.  As
Richard mentioned, we have previous experience with this in the form of
binconfig (and there have been others in the past) and this sort of
thing has universally turned out to be a maintenance headache after a
while.

There's even a comment in the code you quoted:

>> +     # ensure installing systemd-files only (e.g not avahi *.service)

which suggests that some poor soul has previously found that it was
installing things it oughtn't to have done.

p.





  parent reply	other threads:[~2013-02-13 18:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 17:42 [PATCH] systemd.bbclass: Introduce do_install_append and use systemd unitdir Khem Raj
2013-02-12 21:05 ` Burton, Ross
2013-02-12 21:24 ` Richard Purdie
2013-02-12 23:55   ` Andreas Müller
2013-02-13  0:14     ` Richard Purdie
2013-02-13 17:52     ` Phil Blundell [this message]
2013-02-14  2:23       ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360777925.4246.86.camel@phil-desktop.brightsign \
    --to=pb@pbcl.net \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=schnitzeltony@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox