Re: [PATCH 2/4] dbus: Drop libx11 dependency when building without 'x11' distro feature

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2013-02-17 at 10:40 -0300, Otavio Salvador wrote:
> On Sun, Feb 17, 2013 at 4:47 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >>  meta/recipes-core/dbus/dbus.inc | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> >> index 292ab29..cebab28 100644
> >> --- a/meta/recipes-core/dbus/dbus.inc
> >> +++ b/meta/recipes-core/dbus/dbus.inc
> >> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> >>  X11DEPENDS = "virtual/libx11 libsm"
> >>  DEPENDS = "expat virtual/libintl ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> >>  DEPENDS_class-native = "expat-native virtual/libintl-native"
> >> -DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/libx11"
> >> +DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
> >>  RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
> >>  RDEPENDS_class-native = ""
> >
> > This tends to be a really bad idea for dbus-nativesdk. If you install an
> > SDK compiled with these options into PATH only a system which does have
> > x11, it will break functionality in a way unacceptable to users.
> 
> I don't see how it'd break anything being deployed in a toolchain. We
> don't initialize the dbus daemon so it is mostly used to fulfill
> dependencies.

Imagine you source the toolchain setup script. The limited functionality
dbus-launch just got into PATH. Now you run some X application. Things
break.

Cheers,

Richard