public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 4/5] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature
Date: Tue, 19 Feb 2013 09:33:40 -0800	[thread overview]
Message-ID: <1361295220.5927.46.camel@ted> (raw)
In-Reply-To: <CAP9ODKpL1KUmq1L6r9aHarBcG-UcThvEqF0OWwxkfxYiNhbcNw@mail.gmail.com>

On Tue, 2013-02-19 at 13:57 -0300, Otavio Salvador wrote:
> On Tue, Feb 19, 2013 at 1:54 PM, Saul Wold <sgw@linux.intel.com> wrote:
> > On 02/17/2013 09:53 AM, Otavio Salvador wrote:
> >>
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >>   meta/recipes-qt/qt4/nativesdk-qt4-tools.inc | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> >> b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> >> index cfc6fd8..d7ce8dc 100644
> >> --- a/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> >> +++ b/meta/recipes-qt/qt4/nativesdk-qt4-tools.inc
> >> @@ -1,10 +1,10 @@
> >>   DESCRIPTION = "SDK tools for Qt/[X11|Mac|Embedded] version 4.x"
> >> -DEPENDS = "nativesdk-zlib nativesdk-dbus nativesdk-libx11 qt4-native"
> >> +DEPENDS = "nativesdk-zlib nativesdk-dbus
> >> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/nativesdk-libx11', '',
> >> d)} qt4-native"
> >>   SECTION = "libs"
> >>   HOMEPAGE = "http://qt.nokia.com"
> >>   LICENSE = "LGPLv2.1 | GPLv3"
> >>
> >> -INC_PR = "r13"
> >> +INC_PR = "r14"
> >>
> >>   FILESEXTRAPATHS =. "${FILE_DIRNAME}/qt4-${PV}:"
> >>
> >>
> >
> > Does this also need a change to the EXTRA_OECONF to ensure that the x11
> > functionality is disabled by default in the configuration.
> 
> I didn't find this option; it'd be great so we'd ensure it wouldn't
> link against host x11.

We need to find or patch that option in otherwise this is not a viable
change.

Cheers,

Richard





  reply	other threads:[~2013-02-19 17:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-17 17:53 [PATCH v2 1/5] perl: Add auto/XS/Typemap in perl-doc package Otavio Salvador
2013-02-17 17:53 ` [PATCH v2 2/5] dbus: Drop x11 support from nativesdk Otavio Salvador
2013-02-17 17:53 ` [PATCH v2 3/5] libsdl: Use 'virtual/nativesdk-libx11' instead of hardcoding nativesdk-libx11 Otavio Salvador
2013-02-17 17:53 ` [PATCH v2 4/5] qt4-tools: Drop libx11 dependency when building without 'x11' distro feature Otavio Salvador
2013-02-19 16:54   ` Saul Wold
2013-02-19 16:57     ` Otavio Salvador
2013-02-19 17:33       ` Richard Purdie [this message]
2013-02-19 17:37         ` Otavio Salvador
2013-02-17 17:53 ` [PATCH v2 5/5] meta-toolchain-qt.inc: Use CXX when linking Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361295220.5927.46.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox