From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] sanity.bbclass: always use oe.lsb.distro_identifier method
Date: Fri, 1 Mar 2013 18:42:22 +0100 [thread overview]
Message-ID: <1362159742-20602-1-git-send-email-Martin.Jansa@gmail.com> (raw)
* even when /etc/redhat-release or /etc/SuSE-release exists
* don't read /etc/lsb-release manually, NATIVELSBSTRING is not
reading it too
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta/classes/sanity.bbclass | 36 ++++--------------------------------
1 file changed, 4 insertions(+), 32 deletions(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 94c6ce3..06e95e3 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -263,39 +263,11 @@ def check_supported_distro(sanity_data):
if not tested_distros:
return
- if os.path.exists("/etc/redhat-release"):
- f = open("/etc/redhat-release", "r")
- try:
- distro = f.readline().strip()
- finally:
- f.close()
- elif os.path.exists("/etc/SuSE-release"):
- import re
- f = open("/etc/SuSE-release", "r")
- try:
- distro = f.readline()
- # Remove the architecture suffix e.g. (i586)
- distro = re.sub(r' \([a-zA-Z0-9\-_]*\)$', '', distro).strip()
- finally:
- f.close()
- else:
- # Use LSB method
- try:
- distro = oe.lsb.distro_identifier()
- except Exception:
- distro = None
+ try:
+ distro = oe.lsb.distro_identifier()
+ except Exception:
+ distro = None
- if not distro:
- if os.path.exists("/etc/lsb-release"):
- f = open("/etc/lsb-release", "r")
- try:
- for line in f:
- lns = line.split('=')
- if lns[0] == "DISTRIB_DESCRIPTION":
- distro = lns[1].strip('"\n')
- break
- finally:
- f.close()
if distro:
if distro not in [x.strip() for x in tested_distros.split('\\n')]:
bb.warn('Host distribution "%s" has not been validated with this version of the build system; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.' % distro)
--
1.8.1.4
next reply other threads:[~2013-03-01 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 17:42 Martin Jansa [this message]
2013-03-05 10:54 ` [PATCH] sanity.bbclass: always use oe.lsb.distro_identifier method Paul Eggleton
2013-03-05 11:03 ` Burton, Ross
2013-03-06 17:37 ` Martin Jansa
2013-03-06 22:29 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362159742-20602-1-git-send-email-Martin.Jansa@gmail.com \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox