From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] apr: add libtool to SSTATE_SCAN_FILES
Date: Mon, 04 Mar 2013 10:38:27 +0000 [thread overview]
Message-ID: <1362393507.29587.8.camel@ted> (raw)
In-Reply-To: <20130304103306.GF3268@jama>
On Mon, 2013-03-04 at 11:33 +0100, Martin Jansa wrote:
> On Mon, Mar 04, 2013 at 10:11:27AM +0000, Richard Purdie wrote:
> > On Mon, 2013-03-04 at 09:18 +0100, Martin Jansa wrote:
> > > On Sun, Mar 03, 2013 at 08:34:30PM -0500, randy.macleod@windriver.com wrote:
> > > > From: Jackie Huang <jackie.huang@windriver.com>
> > > >
> > > > The hardcoded paths in libtool will cause apache2 compile fail at
> > > > link stage when the package apr is installed from sstate cache, so
> > > > add libtool to SSTATE_SCAN_FILES.
> > > >
> > > > [ CQID: WIND00405372 ]
> > >
> > > You can drop this.
> >
> > Is this really a big problem? I can understand people wanting to be able
> > to track commits back to defect reports...
>
> Not big problem, but isn't link to cgit in their tracking system enough?
>
> That's what I'm using for SHR bugs now, because I cannot assume that people
> using oe-core will know where bug tracker for [SHR #666] is.
I am quite happy for the meaning of some of these to be documented
somewhere with a link to the appropriate bugzillas or other systems.
> I cannot find public windriver bug tracker where I can search
> WIND00405372 to find longer description why this change is needed (I
> know why in this case) - that's why I find yocto bug tags useful, but
> not WIND00*.
As per the commit guidelines, these are additional information and no
excuse for not writing a self-standing commit message. Some will be more
useful than others but I'm not sure it makes sense to remove them just
for the sake of it.
Cheers,
Richard
next prev parent reply other threads:[~2013-03-04 10:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 1:34 [PATCH] apr: add libtool to SSTATE_SCAN_FILES randy.macleod
2013-03-04 8:18 ` Martin Jansa
2013-03-04 10:11 ` Richard Purdie
2013-03-04 10:33 ` Martin Jansa
2013-03-04 10:38 ` Richard Purdie [this message]
2013-03-06 3:13 ` Khem Raj
2013-03-06 16:04 ` Trevor Woerner
2013-03-06 18:07 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362393507.29587.8.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox