Re: [PATCH] cracklib: Generate compiled dict using default dictionary

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2013-03-08 at 08:10 -0500, Colin Walters wrote:
> While cracklib compiles, the generated library's FascistCheck() API
> will look for the default compiled dictionary, fail to find it, and
> invoke exit(1), which then in turn breaks gnome-initial-setup that
> uses cracklib via libpwquality.  (Quality here obviously referring to
> the password, and not the libraries...)
> 
> What we do here is basically the same as what happens in the current
> Fedora spec file, except the latter uses a far larger dictionary.
> 
> To make this work, we need to build cracklib-native because the
> dictionary compiler is written in native code.
> 
> Signed-off-by: Colin Walters <walters@verbum.org>
> ---
>  meta/recipes-extended/cracklib/cracklib_2.8.22.bb | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

The patch doesn't quite do what you think it does. The _appends() stack,
not override and hence the native append is empty. You probably want to
do a:

do_install_append_class-target () {
....
}

(class not virtclass, virtclass is deprecated)

Cheers,

Richard