From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] connman-conf: Move the setup script into /usr/lib/connman
Date: Mon, 18 Mar 2013 14:09:48 +0000 [thread overview]
Message-ID: <1363615788.16482.28.camel@ted> (raw)
In-Reply-To: <1363613908-20116-2-git-send-email-jukka.rissanen@linux.intel.com>
On Mon, 2013-03-18 at 15:38 +0200, Jukka Rissanen wrote:
> The /etc/connman is not suitable for the setup script.
> There are other connman related scripts in /usr/lib/connman
> so moving the wired setup script there.
>
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> ---
> meta/recipes-connectivity/connman/connman-conf.bb | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman-conf.bb b/meta/recipes-connectivity/connman/connman-conf.bb
> index 7b99953..6ecfbfb 100644
> --- a/meta/recipes-connectivity/connman/connman-conf.bb
> +++ b/meta/recipes-connectivity/connman/connman-conf.bb
> @@ -6,16 +6,18 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=80
> SRC_URI_append_qemuall = "file://wired.config \
> file://wired-setup \
> "
> -PR = "r1"
> +PR = "r2"
>
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> +FILES_${PN} = "${localstatedir}/* ${libdir}/*"
> +
> do_install() {
> #Configure Wired network interface in case of qemu* machines
> if test -e ${WORKDIR}/wired.config && test -e ${WORKDIR}/wired-setup; then
> install -d ${D}${localstatedir}/lib/connman
> install -m 0644 ${WORKDIR}/wired.config ${D}${localstatedir}/lib/connman
> - install -d ${D}${sysconfdir}/connman
> - install -m 0755 ${WORKDIR}/wired-setup ${D}${sysconfdir}/connman
> + install -d ${D}${libdir}/connman
> + install -m 0755 ${WORKDIR}/wired-setup ${D}${libdir}/connman
> fi
> }
You've moved the files, fine, but what uses them and do we need to
update the caller?
Cheers,
Richard
next prev parent reply other threads:[~2013-03-18 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 13:38 [PATCH 0/2] connman-conf fixes Jukka Rissanen
2013-03-18 13:38 ` [PATCH 1/2] connman-conf: Move the setup script into /usr/lib/connman Jukka Rissanen
2013-03-18 14:09 ` Richard Purdie [this message]
2013-03-18 14:35 ` Jukka Rissanen
2013-03-19 10:52 ` Iorga, Cristian
2013-03-19 10:55 ` Iorga, Cristian
2013-03-18 13:38 ` [PATCH 2/2] connman-conf: Avoid appending IPv4 address Jukka Rissanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363615788.16482.28.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=jukka.rissanen@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox