Re: [PATCH V3] qemu: Enabled SDL when compiling for target architecture

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2013-04-04 at 15:56 +0000, Prica, Mihai wrote:
> > On Apr 4, 2013, at 5:09 AM, Mihai Prica <mihai.prica@intel.com> wrote:
> > > Enables qemu to run images with video output without the need for vncviewer.
> > >
> > > Signed-off-by: Mihai Prica <mihai.prica@intel.com>
> > > ---
> > > meta/recipes-devtools/qemu/qemu.inc |    4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/recipes-devtools/qemu/qemu.inc
> > > b/meta/recipes-devtools/qemu/qemu.inc
> > > index 1b5b569..06fa88b 100644
> > > --- a/meta/recipes-devtools/qemu/qemu.inc
> > > +++ b/meta/recipes-devtools/qemu/qemu.inc
> > > @@ -1,7 +1,7 @@
> > > DESCRIPTION = "open source processor emulator"
> > > HOMEPAGE = "http://qemu.org"
> > > LICENSE = "GPLv2 & LGPLv2.1"
> > > -DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 pixman dtc"
> > > +DEPENDS = "glib-2.0 zlib alsa-lib virtual/libx11 pixman dtc libsdl"
> > > DEPENDS_class-native = "zlib-native alsa-lib-native glib-2.0-native pixman-
> > native dtc-native"
> > > DEPENDS_class-nativesdk = "nativesdk-zlib nativesdk-libsdl nativesdk-glib-2.0
> > nativesdk-pixman nativesdk-dtc"
> > > RDEPENDS_${PN}_class-nativesdk = "nativesdk-libsdl"
> > > @@ -13,7 +13,7 @@ BBCLASSEXTEND = "native nativesdk"
> > > # QEMU_TARGETS is overridable variable QEMU_TARGETS ?= "arm i386 mips
> > > mipsel mips64 mips64el ppc sh4 x86_64"
> > >
> > > -SDL ?= "--disable-sdl"
> > > +SDL ?= ""
> > 
> > I think this is not acceptable change. Since many systems are headless and its
> > useless for them secondly, converting this to PACKAGECONFIG and keeping the
> > behavior as it was would be fine.
> 
> I sent a patch to meta-virtualization that just enabled SDL using a bbappend and the
> maintainers said I should to integrate this into poky. I talked with Richard and he 
> said I should use a PACKAGECONFIG and enable sdl by default for the target. For 
> headless images the user can disable it. I sent a V2 with this solution. Saul replied 
> and told me there are some problems with this approach and I should stick with the
> SDL variable.

I'd ultimately like to see PACKAGECONFIG used here but we haven't
managed the right patchset yet so I took this one earlier today as a
short term fix :/.

Cheers,

Richard