From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-core layer <openembedded-core@lists.openembedded.org>, Patches
Subject: Re: [oe][PATCH] eglinfo: Add recipes for x11 and fb backends
Date: Thu, 04 Apr 2013 23:36:27 +0100 [thread overview]
Message-ID: <1365114987.6526.120.camel@ted> (raw)
In-Reply-To: <CAP9ODKoHXQt=HN7VkyeE+rWXkVV+hPLJhPFRUne+mCm7phhEdQ@mail.gmail.com>
On Thu, 2013-04-04 at 14:09 -0300, Otavio Salvador wrote:
> On Thu, Apr 4, 2013 at 12:41 PM, Saul Wold <sgw@linux.intel.com> wrote:
> >
> > I am going to defer this to 1.5 when it opens up, I still need to review the
> > recipe, but wanted to give you a heads up about the deferral.
>
> Any reasoning to defer it when it adds a good tool for validation and
> test? It also offers very low risk of breaking something.
We're two weeks before release and meant to be bug fixing now, new
features add risk.
You say this patch is low risk but it will actually break builds. Why?
It has machine specific code but isn't marked as machine specific and it
will not work well in world builds for example. That is just the part I
can spot from looking at it but it means its not been widely tested.
Yes, we can fix these things but I really want to focus on the bugs we
have right now, not fixing new code and adding new build failures.
So Saul is right here in deferring this.
Cheers,
Richard
next prev parent reply other threads:[~2013-04-04 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 19:26 [oe][PATCH] eglinfo: Add recipes for x11 and fb backends Carlos Rafael Giani
2013-04-04 15:41 ` Saul Wold
2013-04-04 17:09 ` Otavio Salvador
2013-04-04 22:36 ` Richard Purdie [this message]
2013-08-28 8:29 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365114987.6526.120.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox