Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: bitbake-devel@lists.openembedded.org,
	openembedded-core@lists.openembedded.org
Subject: Re: [bitbake-devel] Checksum failure encountered with download
Date: Thu, 11 Apr 2013 22:40:19 +0100	[thread overview]
Message-ID: <1365716419.16702.63.camel@ted> (raw)
In-Reply-To: <20130411133031.GF2477@jama>

On Thu, 2013-04-11 at 15:30 +0200, Martin Jansa wrote:
> Hi,
> 
> when fetcher fails with ChecksumError it shows error like in subject and
> tries another MIRRORs
> 
> Would anyone object to keep fetched source with wrong checksum in
> downloads directory (renamed so it does not conflict with file with
> correct checksum downloaded later)?
> 
> Right now it just removes the file:
>                         # Remove any incomplete fetch
>                         m.clean(ud, self.d)
> 
> The problem with this is when upstream repacks some archive I would like
> to be able to compare old tarball and new one.
> 
> My proposal is to add md5sum of downloaded file to ChecksumError and
> rename it to <file>.<md5sum> in "if isinstance(e, ChecksumError):"
> 
> Does it make sense (should I send patch for this)?

I'm fine with that.

Cheers,

Richard





  reply	other threads:[~2013-04-11 21:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 13:30 Checksum failure encountered with download Martin Jansa
2013-04-11 21:40 ` Richard Purdie [this message]
2013-04-12 19:44 ` [bitbake-devel] " Trevor Woerner
2013-04-12 20:37   ` Martin Jansa
2013-04-15 13:41     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365716419.16702.63.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox