Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: A success of the new performance metrics
Date: Mon, 15 Apr 2013 14:40:00 +0100	[thread overview]
Message-ID: <1366033200.8670.43.camel@ted> (raw)

Sometimes people wonder why I take so long to merge certain patches. The
issue is that if some core area of the code changes, it can have a
ripple effect on the rest of the system.

One of the goals of 1.4 is to improve performance. In order to
demonstrate we did (and to be better able to track regressions) this
meant improving our performance testing so we now have:

https://wiki.yoctoproject.org/wiki/Performance_Test

The QA team just produced the numbers for 1.4M6.rc1. In case its not
clear, M6 is the final release milestone. The results caused them to
send me an urgent email "you might want to look at the numbers". They're
right, we seem to have regressed badly between M5.rc3 and M6.rc1 on
multiple benchmarks. Eeek!

Paul was able to track this down to a recent bitbake change:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=05d4f94c25b14ca99a1df01030edc00125f95405

Upon looking at the patch and thinking performance, it was immediately
obvious to a seasoned bitbake performance hacker that the usage of
keys() would cripple us.

So its sad I didn't spot this on the initial review/testing. On the
other hand its great that the benchmarks caused us to as the right
questions and find a problem. Thankfully its easy to fix the problem as
we don't need keys() here.

Lets hope the rc2 benchmarks look a bit better :)

Cheers,

Richard






                 reply	other threads:[~2013-04-15 13:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366033200.8670.43.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox