From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] pango: add libpng to DEPENDS
Date: Tue, 16 Apr 2013 10:54:18 +0100 [thread overview]
Message-ID: <1366106058.8670.89.camel@ted> (raw)
In-Reply-To: <1366103412-10924-1-git-send-email-koen@dominion.thruhere.net>
On Tue, 2013-04-16 at 11:10 +0200, Koen Kooi wrote:
> Pango links indirectly to libpng through the cairo-png dependency, but
> does encode the libpng version in its .la files. Changing libpng
> versions will make a rebuild fail, so let's cheat a bit to let sstate
> rebuild pango as well to get around this.
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> meta/recipes-graphics/pango/pango.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This doesn't follow. If pango -> cairo -> libpng and libpng changes,
both cairo and pango will rebuild.
What might be the problem is that autotools (or more likely libtool)
isn't rebuilding correctly. This was solved with the separate build
directory code. Have you enabled that?
Cheers,
Richard
> diff --git a/meta/recipes-graphics/pango/pango.inc b/meta/recipes-graphics/pango/pango.inc
> index f622903..c1beb9e 100644
> --- a/meta/recipes-graphics/pango/pango.inc
> +++ b/meta/recipes-graphics/pango/pango.inc
> @@ -10,7 +10,7 @@ SECTION = "libs"
> LICENSE = "LGPLv2.0+"
>
> X11DEPENDS = "virtual/libx11 libxft"
> -DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv cairo elfutils harfbuzz"
> +DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv cairo elfutils harfbuzz libpng"
>
> PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
> PACKAGECONFIG[x11] = "--with-x,--without-x,${X11DEPENDS}"
next prev parent reply other threads:[~2013-04-16 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 9:10 [PATCH] pango: add libpng to DEPENDS Koen Kooi
2013-04-16 9:54 ` Richard Purdie [this message]
2013-04-16 9:59 ` Koen Kooi
2013-04-16 10:08 ` Richard Purdie
2013-04-16 10:15 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366106058.8670.89.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox