From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dan.rpsys.net ([93.97.175.187]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1USnyF-0008Ip-D7 for openembedded-core@lists.openembedded.org; Thu, 18 Apr 2013 14:29:51 +0200 Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r3ICChBf002337; Thu, 18 Apr 2013 13:12:43 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Dd_yLO_cdJSo; Thu, 18 Apr 2013 13:12:43 +0100 (BST) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r3ICCbQa002325 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Thu, 18 Apr 2013 13:12:38 +0100 Message-ID: <1366287118.10502.58.camel@ted> From: Richard Purdie To: Enrico Scholz Date: Thu, 18 Apr 2013 13:11:58 +0100 In-Reply-To: References: <1366211991.25282.34.camel@ted> <1366280909.10502.54.camel@ted> X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] packagegroup: Add init-manager sanity check X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2013 12:30:00 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Thu, 2013-04-18 at 12:39 +0200, Enrico Scholz wrote: > Richard Purdie writes: > > >> > Currently, you can set VIRTUAL-RUNTIME_init_manager to an init > >> > system that isn't in DISTRO_FEATURES. This leads to head scratching > >> > over unbootable images. > >> > >> Because this sanity check is placed into an anonymous function, this > >> change affects also images which do not not include packagegroup-core* > >> in their images and are not using VIRTUAL-RUNTIME_init_manager at all. > > > > Affects in that it runs the anonymous python fragment but does nothing? > > no; the 'parsing recipes' phase throws an exceptions > > | ERROR: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES## | ETA: 00:00:14 > | ERROR: Unable to parse /srv/oe/dev/org.openembedded.core/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb: Exited with "1" > | ERROR: Command execution failed: Exited with 1 > > > Of course, I can BBMASK out these packagegroup-core recipes or simply > define VIRTUAL-RUNTIME_init_manager. Hmm, I understand now. The way I see this is that the system can't know if anything in your environment is going to use packagegroup-* or not. Given that, I do think this is a valid warning since whilst you know not to use them, others may not. > > Other proposals for solutions are welcome. I thought it better to > > catch a common user misconfiguration than generate broken images > > silently though. > > You can put this check into e.g. do_configure[prefuncs]. So it errors at build time some time later? Where we can is it not better to inform the user of configuration issues earlier? Cheers, Richard