Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Colin Walters <walters@verbum.org>
Cc: Burton, mclasen@redhat.com,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gdk-pixbuf: Fix libpng determinism issues
Date: Fri, 19 Apr 2013 13:59:57 +0100	[thread overview]
Message-ID: <1366376397.10502.126.camel@ted> (raw)
In-Reply-To: <1366030768.32176.9.camel@localhost>

On Mon, 2013-04-15 at 08:59 -0400, Colin Walters wrote:
> On Mon, 2013-04-15 at 13:22 +0100, Richard Purdie wrote:
> > On Mon, 2013-04-15 at 08:12 -0400, Colin Walters wrote:
> > > On Mon, 2013-04-15 at 12:31 +0100, Richard Purdie wrote:
> > > 
> > > > It will make our builds work again for now until the next time someone
> > > > upgrades libpng and and then it will potentially silently start using an
> > > > old version in some builds :(.
> > > 
> > > So something like the attached on top of the previous patch?
> > > 
> > > If this looks good I'll push both to master.
> > 
> > Looks good to me, thanks!
> 
> Both pushed to git, thanks.

Much appreciated!

> <nag>
> If OE was building from git as it should, your original patch could have
> been a ready-to-upstream "git format-patch" style instead of the default
> "Upstream-Status: inappropriate" non-git patches =/
> </nag>

Noted, although I doubt we'll be using git SRC_URIs for everything any
time soon for a variety of reasons. I would love to see the option of
building most things from bleeding source but that would require a lot
of work which we don't have the bandwidth for.

Cheers,

Richard





  reply	other threads:[~2013-04-19 13:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 10:25 [PATCH] gdk-pixbuf: Fix libpng determinism issues Richard Purdie
2013-04-14 13:02 ` Colin Walters
2013-04-14 15:33   ` Richard Purdie
2013-04-15 10:08     ` Colin Walters
2013-04-15 10:14       ` Koen Kooi
2013-04-15 11:31       ` Richard Purdie
2013-04-15 12:12         ` Colin Walters
2013-04-15 12:22           ` Richard Purdie
2013-04-15 12:59             ` Colin Walters
2013-04-19 12:59               ` Richard Purdie [this message]
2013-04-19 13:41                 ` Koen Kooi
2013-04-19 17:17                   ` Colin Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366376397.10502.126.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mclasen@redhat.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=walters@verbum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox