Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] image.bbclass: Don't mark do_rootfs and do_build as nostamp
Date: Mon, 29 Apr 2013 15:54:50 +0100	[thread overview]
Message-ID: <1367247290.5379.31.camel@ted> (raw)
In-Reply-To: <2359996.YCG7Bud1Ca@helios>

On Mon, 2013-04-29 at 15:45 +0100, Paul Eggleton wrote:
> So upon further reflection, I'm guessing my objections were only really about 
> changing the status quo, as well as a lot of my own testing involving re-
> running the image creation step without really changing anything other than 
> the code that contributes to do_rootfs; it could be argued that my use case 
> would be equally served by me setting nostamp locally or using -f, and 
> everyone else having the benefit of not rebuilding the image when not needed.

Remember as well that if you change the rootfs code, that will change
the rootfs stamp and the image will get regenerated. So it should even
work for your use case, if it doesn't, we have bigger dependencies
issues which we should fix which would be the real problems.

> Given that this is a departure from previously established behaviour, I do 
> think we need to give a more of an explanation in the commit message than the 
> proposed patch however; something that summarises Richard's explanation above 
> would be informative.

Agreed, Phil's commit message missed out a few important points.

Cheers,

Richard




  reply	other threads:[~2013-04-29 15:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 11:30 [PATCH] image.bbclass: Don't mark do_rootfs and do_build as nostamp Phil Blundell
2013-04-27  8:34 ` Paul Eggleton
2013-04-27  9:08   ` Richard Purdie
2013-04-27  9:20     ` Koen Kooi
2013-04-29 14:45     ` Paul Eggleton
2013-04-29 14:54       ` Richard Purdie [this message]
2013-04-29 18:33         ` Phil Blundell
2013-05-02 18:05           ` Saul Wold
2013-04-27  9:24   ` Phil Blundell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367247290.5379.31.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox