From: Phil Blundell <pb@pbcl.net>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] insane.bbclass: Add missing R* variables to pkgvarcheck
Date: Thu, 02 May 2013 11:59:36 +0100 [thread overview]
Message-ID: <1367492376.14512.239.camel@phil-desktop.brightsign> (raw)
In-Reply-To: <1572577.Dfl22j8Qhu@helios>
On Thu, 2013-05-02 at 11:36 +0100, Paul Eggleton wrote:
> On Thursday 02 May 2013 11:16:30 Phil Blundell wrote:
> > On Wed, 2013-02-06 at 14:25 +0100, Martin Jansa wrote:
> > > * check also RSUGGESTS, RCONFLICTS, RPROVIDES, RREPLACES
> >
> > These are already checked by recipe_sanity.bbclass. There's probably no
> > need to check them again here.
>
> recipe_sanity.bbclass doesn't get used by default - I guess you are enabling
> it explicitly?
Yeah, or rather, it's used by default in meta-micro.
> I wonder if we should either (a) move all the recipe checks to
> recipe_sanity.bbclass and enable it by default, or (b) move any currently
> there and not covered by insane.bbclass to insane.bbclass and delete
> recipe_sanity.bbclass.
Either of those sounds reasonable enough to me. I think the original
concept was that recipe_sanity was for errors that you could identify
statically at recipe parse time, and insane.bbclass was for checks
against the output artifacts (that you could only do after compiling and
packaging) but that line does seem to have gotten a bit blurred over
time.
p.
prev parent reply other threads:[~2013-05-02 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 13:25 [PATCH] insane.bbclass: Add missing R* variables to pkgvarcheck Martin Jansa
2013-05-02 10:16 ` Phil Blundell
2013-05-02 10:36 ` Paul Eggleton
2013-05-02 10:59 ` Phil Blundell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367492376.14512.239.camel@phil-desktop.brightsign \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox