From: Phil Blundell <pb@pbcl.net>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gcc-runtime: Avoid error when trying to remove nonexistent directories
Date: Thu, 02 May 2013 14:13:57 +0100 [thread overview]
Message-ID: <1367500437.14512.249.camel@phil-desktop.brightsign> (raw)
In-Reply-To: <CAJTo0LZf1D75XU5CUWqyvNbY5A1kbXufiJDBKmc-Bmf9RxAjCQ@mail.gmail.com>
On Thu, 2013-05-02 at 13:54 +0100, Burton, Ross wrote:
> On 2 May 2013 13:19, Phil Blundell <pb@pbcl.net> wrote:
> > If we didn't build libgomp then we won't have installed anything into
> > ${infodir} or ${libdir}/gcc/${TARGET_SYS}/${BINV}/finclude. Check
> > whether those directories exist before trying to remove them, else we
> > will lose.
>
> Isn't it neater to use rm -rf?
The original code goes to some trouble to use "rmdir
--ignore-fail-on-non-empty", which I assume means that there are some
circumstances where those directories do contain other files that we
want to keep. Using "rm -rf" would obviously blow the whole thing away.
p.
prev parent reply other threads:[~2013-05-02 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 12:19 [PATCH] gcc-runtime: Avoid error when trying to remove nonexistent directories Phil Blundell
2013-05-02 12:54 ` Burton, Ross
2013-05-02 13:13 ` Phil Blundell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367500437.14512.249.camel@phil-desktop.brightsign \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox