Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/4] Fixes for makedevs
Date: Wed, 29 May 2013 22:40:24 +0100	[thread overview]
Message-ID: <1369863624.14887.247.camel@ted> (raw)
In-Reply-To: <cover.1369839249.git.pkj@axis.com>

On Wed, 2013-05-29 at 16:55 +0200, Peter Kjellerstedt wrote:
> When I wanted to create devices from a package I stumbled upon a couple
> of problems with the makedevs program. Most notable was that it failed
> to set the correct uid/gid for devices created as part of a block (i.e.,
> with a count > 0).
> 
> The following changes since commit efb8a460d2a977dbd481a0650fba8eb637c65bec:
> 
>   package.bbclass: Fix sources contents (2013-05-14 08:52:47 +0300)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib pkj/makedevs
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/makedevs
> 
> Peter Kjellerstedt (4):
>   makedevs: Create blocks of devices with the correct uid/gid
>   makedevs: Correct the device number calculation for blocks of devices
>   makedevs: Make the mode number readable in debug messages
>   makedevs: Avoid unnecessary timestamp calculation

These look good to me but could you push a branch with signed-off-by
lines in the commits please?

Cheers,

Richard



  parent reply	other threads:[~2013-05-29 21:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 14:55 [PATCH 0/4] Fixes for makedevs Peter Kjellerstedt
2013-05-29 14:55 ` [PATCH 1/4] makedevs: Create blocks of devices with the correct uid/gid Peter Kjellerstedt
2013-05-29 14:55 ` [PATCH 2/4] makedevs: Correct the device number calculation for blocks of devices Peter Kjellerstedt
2013-05-29 14:55 ` [PATCH 3/4] makedevs: Make the mode number readable in debug messages Peter Kjellerstedt
2013-05-29 14:56 ` [PATCH 4/4] makedevs: Avoid unnecessary timestamp calculation Peter Kjellerstedt
2013-05-29 21:40 ` Richard Purdie [this message]
2013-05-30  7:29   ` [PATCH 0/4] Fixes for makedevs Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369863624.14887.247.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox