From: Tom Zanussi <tom.zanussi@intel.com>
To: Ning Zhang <ning.zhang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] yocto_kernel: modify the msg when adding duplicate items
Date: Mon, 03 Jun 2013 07:22:20 -0500 [thread overview]
Message-ID: <1370262140.14580.21.camel@empanada> (raw)
In-Reply-To: <fc2f4a65e654e548bfba36505ed37285270667f5.1370228342.git.ning.zhang@windriver.com>
On Mon, 2013-06-03 at 13:21 +0800, Ning Zhang wrote:
> Privious check-in "yocto_kernel: check current items before add a
> new one" had been merged before I apply the feedback from Zanussi, Tom.
> Now fix it as a new patch.
>
> This fix modify the output message when customer adding duplicate
> items.
>
> [YOCTO #4558]
>
> Signed-off-by: Ning Zhang <ning.zhang@windriver.com>
Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
> scripts/lib/bsp/kernel.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/bsp/kernel.py b/scripts/lib/bsp/kernel.py
> index 9ed6e94..94ae950 100644
> --- a/scripts/lib/bsp/kernel.py
> +++ b/scripts/lib/bsp/kernel.py
> @@ -260,7 +260,7 @@ def yocto_kernel_config_add(scripts_path, machine, config_items):
> print "\t%s" % n
>
> if len(dup_items) > 0:
> - output="Below item%s already exist%s in current configuration, ignore %s" % \
> + output="The following item%s already exist%s in the current configuration, ignoring %s:" % \
> (("","s", "it") if len(dup_items)==1 else ("s", "", "them" ))
> print output
> for n in dup_items:
prev parent reply other threads:[~2013-06-03 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:21 [PATCH 0/1] yocto_kernel: modify the msg when adding duplicate items Ning Zhang
2013-06-03 5:21 ` [PATCH 1/1] " Ning Zhang
2013-06-03 12:22 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370262140.14580.21.camel@empanada \
--to=tom.zanussi@intel.com \
--cc=ning.zhang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox