Re: [PATCH] tune-cortexa72-cortexa53: Add tune

[Mark Hatle <mark.hatle@kernel.crashing.org>]

On 12/13/19 4:03 PM, Joshua Watt wrote:
> Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g.  Rockchip
> RK3399
> 
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  .../include/tune-cortexa72-cortexa53.inc       | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> 
> diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> new file mode 100644
> index 00000000000..30e49d20769
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> @@ -0,0 +1,18 @@
> +DEFAULTTUNE ?= "cortexa72-cortexa53"
> +require conf/machine/include/arm/arch-armv8a.inc
> +
> +TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
> +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
> +
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
> +
> +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
> +
> +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
> +
> +# Little Endian base configs
> +AVAILTUNES += "cortexa72-cortexa53"
> +ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"

I'm wondering if the pkgarch should be shorter.. This really does make package
names very long.  (I don't know offhand if that is an actual problem or not.)

Also a similar tune has been used by NXP and Wind River.  So hopefully we don't
end up with conflicts.

--Mark

> +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa72-cortexa53"
> +BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
>