From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id 997FC601AF for ; Wed, 19 Jun 2013 11:57:59 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r5JC46u6019461; Wed, 19 Jun 2013 13:04:06 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RXxy03y2BpTA; Wed, 19 Jun 2013 13:04:06 +0100 (BST) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r5JC416f019458 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Wed, 19 Jun 2013 13:04:03 +0100 Message-ID: <1371643063.20823.171.camel@ted> From: Richard Purdie To: Kang Kai Date: Wed, 19 Jun 2013 12:57:43 +0100 In-Reply-To: <51C19398.9080401@windriver.com> References: <1371629601.20823.161.camel@ted> <51C19398.9080401@windriver.com> X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 2/2] strace: update to 4.8 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2013 11:58:00 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Wed, 2013-06-19 at 19:18 +0800, Kang Kai wrote: > On 2013年06月19日 16:13, Richard Purdie wrote: > > On Wed, 2013-06-19 at 13:34 +0800, Kai Kang wrote: > >> Update strace to 4.8. > >> > >> * Update License file. > >> * Remove the backport patches which are already in version 4.8. > >> * Add file git-version-gen from git repo. Without this file configure > >> fails. > >> * Add libaio and acl to PACKAGECONFIG for target package. Make libaio as a > >> dependency by default which could be covered easily. > >> > >> Signed-off-by: Kai Kang > > [...] > > > >> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb > >> new file mode 100644 > >> index 0000000..eb9f660 > >> --- /dev/null > >> +++ b/meta/recipes-devtools/strace/strace_4.8.bb > >> @@ -0,0 +1,32 @@ > >> +DESCRIPTION = "strace is a system call tracing tool." > >> +HOMEPAGE = "http://strace.sourceforge.net" > >> +SECTION = "console/utils" > >> +LICENSE = "BSD" > >> +LIC_FILES_CHKSUM = "file://COPYING;md5=124500c21e856f0912df29295ba104c7" > >> +PR = "r0" > >> + > >> +SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.xz \ > >> + file://git-version-gen" > >> + > >> +SRC_URI[md5sum] = "c575ef43829586801f514fd91bfe7575" > >> +SRC_URI[sha256sum] = "f492291f07a7c805c07a8395cce1ea054a6401ad414f4cc12185672215e1d7f8" > >> +inherit autotools > >> + > >> +PACKAGECONFIG_class-target ?= "libaio" > >> +PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" > >> + > >> +PACKAGECONFIG[libaio] = ",,libaio," > >> +PACKAGECONFIG[acl] = ",,acl," > > Are there not --enable/--disable type options we can pass into configure > > here to ensure build are deterministic? > > Configure just check headers, no such --enable/--disable options. Then we have a problem since something like: bitbake acl bitbake strace will build strace with acl enabled even though its not set in DISTRO_FEATURES and this means builds are not deterministic. We need to fix that. > > Please also send this with move detection enabled in git so we get a > > diff rather than a file removal/addition correctly shown (-M option to > > git format-patch for example). > > It maybe changes too much that git doesn't take that as 'rename'. > I will take 'git mv' as a seperate commit but that commit is not > buildable, I will say that in comment. You can set to a different threshold with -M30 or similar... Cheers, Richard