Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Sona Sarmadi <sona.sarmadi@enea.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] bash ptest: Sed away the Makefile dependency to remove error messages.
Date: Thu, 20 Jun 2013 09:45:58 +0100	[thread overview]
Message-ID: <1371717958.20823.218.camel@ted> (raw)
In-Reply-To: <1371716874-42538-1-git-send-email-sona.sarmadi@enea.com>

On Thu, 2013-06-20 at 10:27 +0200, Sona Sarmadi wrote:
> From: Björn Stenberg <bjst@enea.com>
> 
> Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
> ---
>  meta/recipes-extended/bash/bash-4.2/run-ptest |    2 +-
>  meta/recipes-extended/bash/bash.inc           |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

I'm sure this is a good change but could you expand a little on what it
does and why? Which error message is getting fixed? As well as the
summary, commit messages should have a description.

Cheers,

Richard

> diff --git a/meta/recipes-extended/bash/bash-4.2/run-ptest b/meta/recipes-extended/bash/bash-4.2/run-ptest
> index 66f1eee..8dd3b99 100644
> --- a/meta/recipes-extended/bash/bash-4.2/run-ptest
> +++ b/meta/recipes-extended/bash/bash-4.2/run-ptest
> @@ -1,2 +1,2 @@
>  #!/bin/sh
> -echo Makefile: | make -f Makefile -f - -k THIS_SH=/bin/bash BUILD_DIR=. runtest
> +make -k THIS_SH=/bin/bash BUILD_DIR=. runtest
> diff --git a/meta/recipes-extended/bash/bash.inc b/meta/recipes-extended/bash/bash.inc
> index c619f82..2f4519c 100644
> --- a/meta/recipes-extended/bash/bash.inc
> +++ b/meta/recipes-extended/bash/bash.inc
> @@ -40,6 +40,7 @@ do_install_append () {
>  do_install_ptest () {
>  	make INSTALL_TEST_DIR=${D}${PTEST_PATH}/tests install-test
>  	cp ${B}/Makefile ${D}${PTEST_PATH}
> +        sed -i 's/^Makefile/_Makefile/' ${D}${PTEST_PATH}/Makefile
>  }
>  
>  pkg_postinst_${PN} () {




  reply	other threads:[~2013-06-20  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  8:27 [PATCH] bash ptest: Sed away the Makefile dependency to remove error messages Sona Sarmadi
2013-06-20  8:45 ` Richard Purdie [this message]
2013-06-24  7:45 ` [PATCH v2] " Sona Sarmadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371717958.20823.218.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sona.sarmadi@enea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox