Re: [PATCH 1/1] Limit the kbdrate application to x86, mips and sparc.

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2013-06-24 at 08:18 -0700, Saul Wold wrote:
> On 06/24/2013 12:45 AM, jhuang0 wrote:
> >
> >
> > On 6/24/2013 3:23 PM, Paul Barker wrote:
> >> On 24 Jun 2013 07:28, <jackie.huang@windriver.com
> >> <mailto:jackie.huang@windriver.com>> wrote:
> >>  >
> >>  > From: Jackie Huang <jackie.huang@windriver.com
> >> <mailto:jackie.huang@windriver.com>>
> >>  >
> >>  > The code relies on hardware specific memory locations to access
> >>  > and modify the keyboard repeat rate.  It also requires read/write
> >>  > access to /dev/port which doesn't exist on every architecture's
> >>  > root fs.  The defect was raised for Qemu PowerPC but it also fails on
> >>  > ARM.  The keyboard emulation in qemuppc is for an ADB (Apple
> >> Desktop Bus)
> >>  > device and not compatible with an Intel driver.  There's also no
> >>  > indication in the documentation that the code should work on
> >>  > anything other than Intel architecture but it also works on MIPS.
> >>  >
> >>
> >>  > ++#if !(  defined(__i386__)   \
> >>  > ++     || defined(__x86_64__) \
> >>  > ++     || defined(__mips__)   \
> >>  > ++     || defined(__sparc___))
> >>  > ++
> >>  > ++      fprintf(stderr,
> >>  > ++              "ERROR:  %s should only be used on MIPS, x86 and
> >> Sparc archicture boards\n", basename(argv[0]));
> >>  > ++        exit(1);
> >>  > ++#endif
> >>
> >> Would it be better to detect the target platform in the build system and
> >> skip building the kbdrate program for architectures it won't work on
> >> rather than building and installing a known broken program?
> >
> > Yeah, it should be better, I will check if we can do that.
> >
> Use COMPATIBLE_MACHINE

We're after to take out a single binary, not the whole recipe?

Cheers,

Richard