From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id A6AAF600FB for ; Tue, 25 Jun 2013 17:08:18 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r5PHF03L020941 for ; Tue, 25 Jun 2013 18:15:00 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OIUhwhBZgM72 for ; Tue, 25 Jun 2013 18:15:00 +0100 (BST) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r5PHErEp020938 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT) for ; Tue, 25 Jun 2013 18:14:55 +0100 Message-ID: <1372180081.9930.91.camel@ted> From: Richard Purdie To: openembedded-core Date: Tue, 25 Jun 2013 18:08:01 +0100 X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Subject: [PATCH] sanity.bbclass: Add check for @ character in build directory name X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2013 17:08:19 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit The @ character is not escaped properly in too many places within the system to easily support it so add the character to the list of blacklisted characters. Also tweak the other messages and ensure that all appropriate error messages are disabled in one go. Signed-off-by: Richard Purdie --- diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 622bb41..cf23982 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -589,10 +589,12 @@ def check_sanity_everybuild(status, d): pass oeroot = d.getVar('COREBASE') - if oeroot.find ('+') != -1: - status.addresult("Error, you have an invalid character (+) in your COREBASE directory path. Please move the installation to a directory which doesn't include a +.") - elif oeroot.find (' ') != -1: - status.addresult("Error, you have a space in your COREBASE directory path. Please move the installation to a directory which doesn't include a space.") + if oeroot.find('+') != -1: + status.addresult("Error, you have an invalid character (+) in your COREBASE directory path. Please move the installation to a directory which doesn't include any + characters.") + if oeroot.find('@') != -1: + status.addresult("Error, you have an invalid character (@) in your COREBASE directory path. Please move the installation to a directory which doesn't include any @ characters.") + if oeroot.find(' ') != -1: + status.addresult("Error, you have a space in your COREBASE directory path. Please move the installation to a directory which doesn't include a space since autotools doesn't support this.") # Check that TMPDIR hasn't changed location since the last time we were run tmpdir = d.getVar('TMPDIR', True)