From: Colin Walters <walters@verbum.org>
To: Stefan Stanacar <stefanx.stanacar@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC PATCH v2 3/8] lib/oeqa/utils/sshcontrol.py: helper module for running remote commands
Date: Sun, 07 Jul 2013 17:55:31 -0400 [thread overview]
Message-ID: <1373234131.5334.17.camel@localhost> (raw)
In-Reply-To: <a29e7a16581e848d017a56de42e4ee751639d529.1373013888.git.stefanx.stanacar@intel.com>
On Fri, 2013-07-05 at 12:27 +0300, Stefan Stanacar wrote:
> + actualcmd = "ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -l root %s '%s'" % (self.host, cmd)
This is going to fail if cmd contains a single quote. Personally, I
*always* pass around subprocess arguments as an array. Anything else is
going to lead to quoting problems.
next prev parent reply other threads:[~2013-07-07 21:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 9:27 [RFC PATCH v2 0/8] Proposed implementation of a new runtime tests framework Stefan Stanacar
2013-07-05 9:27 ` [RFC PATCH v2 1/8] classes/testimage.bbclass: new class for image tests Stefan Stanacar
2013-07-05 9:27 ` [RFC PATCH v2 2/8] lib/oeqa/oetest.py: base module for all runtime unittests Stefan Stanacar
2013-07-05 9:27 ` [RFC PATCH v2 3/8] lib/oeqa/utils/sshcontrol.py: helper module for running remote commands Stefan Stanacar
2013-07-07 21:55 ` Colin Walters [this message]
2013-07-09 16:50 ` Stanacar, StefanX
2013-07-05 9:27 ` [RFC PATCH v2 4/8] lib/oeqa/utils/oeqemuconsole.py: handle qemu serial console connection Stefan Stanacar
2013-07-05 9:27 ` [RFC PATCH v2 5/8] lib/oeqa/utils/qemurunner.py: class to handle qemu instance Stefan Stanacar
2013-07-05 9:27 ` [RFC PATCH v2 6/8] lib/oeqa/utils/decorators.py: decorators for test methods Stefan Stanacar
2013-07-05 9:27 ` [RFC PATCH v2 7/8] lib/oeqa/runtime: image sanity tests Stefan Stanacar
2013-07-05 9:27 ` [RFC PATCH v2 8/8] lib/oeqa/runtime: add gcc test Stefan Stanacar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373234131.5334.17.camel@localhost \
--to=walters@verbum.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=stefanx.stanacar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox