From: Phil Blundell <pb@pbcl.net>
To: Bian Naimeng <biannm@cn.fujitsu.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration
Date: Mon, 29 Jul 2013 16:36:09 +0100 [thread overview]
Message-ID: <1375112169.13247.44.camel@phil-desktop.brightsign> (raw)
In-Reply-To: <51F5E948.4070107@cn.fujitsu.com>
On Mon, 2013-07-29 at 12:02 +0800, Bian Naimeng wrote:
> qemux86.conf: provide a common qemux86 machine configuration,
> so developer/distributor can customize their specific one.
>
> Although, we can modify the meta/conf/machine/qemux86.conf to customize our
> configuration, but it's uncomfortable for developer/distributor maintaining
> their branch.
> After applying this patch, developer can tell poky using their machine
> configuration by prepending their layer to BBPATH(Of course,
> the bblayers.conf should be adapted to it).
I don't really understand the purpose of this patch. Surely there is
nothing to stop you from shipping an overlay qemux86.conf in some other
layer today, right? What exactly is the advantage of this extra
indirection through an .inc file?
Also, as a side note, your patches 1/6, 2/6 and 6/6 all said
"qemuarm.conf" in the subject lines but only the last of them actually
contained changes to qemuarm.conf.
Also also, the patches in this form are quite hard to follow. Did you
use "git format-patch -M" when creating them?
p.
next prev parent reply other threads:[~2013-07-29 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 3:58 [RFC][PATCH 0/6]provide a common machine configuration to developer for customizing specific machine Bian Naimeng
2013-07-29 4:02 ` [RFC][PATCH 1/6]qemuarm.conf: provide a common qemuarm machine configuration Bian Naimeng
2013-07-29 15:36 ` Phil Blundell [this message]
2013-07-30 1:51 ` Bian Naimeng
2013-07-30 8:15 ` Martin Jansa
2013-07-30 8:55 ` Bian Naimeng
2013-07-29 4:04 ` [RFC][PATCH 2/6]qemuarm.conf: provide a common qemux86-64 " Bian Naimeng
2013-07-29 4:05 ` [RFC][PATCH 3/6]qemuppc.conf: provide a common qemuppc " Bian Naimeng
2013-07-29 4:07 ` [RFC][PATCH 4/6]qemumips.conf: provide a common qemumips " Bian Naimeng
2013-07-29 4:08 ` [RFC][PATCH 5/6]qemumips64.conf: provide a common qemumips64 " Bian Naimeng
2013-07-29 4:09 ` [RFC][PATCH 6/6]qemuarm.conf: provide a common qemuarm " Bian Naimeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375112169.13247.44.camel@phil-desktop.brightsign \
--to=pb@pbcl.net \
--cc=biannm@cn.fujitsu.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox