Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Colin Walters <walters@verbum.org>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] util-linux: Update for swapoff being a separate binary
Date: Mon, 29 Jul 2013 13:48:13 -0400	[thread overview]
Message-ID: <1375120093.15230.63.camel@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

In older versions of util-linux, swapon and swapoff were the
same binary, and it did runtime detection.  But since v2.22
which is util-linux commit 6cf8d46ceefe9a7, they are separate
binaries.

This patch is necessary to make the util-linux version of
swapoff work at all - currently in OE swapoff = swapon, which
is clearly broken =)

Probably most OE consumers use the busybox swapoff and hence
this has gone unnoticed.

Signed-off-by: Colin Walters <walters@verbum.org>
---
 meta/recipes-core/util-linux/util-linux.inc |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)




[-- Attachment #2: 0001-util-linux-Update-for-swapoff-being-a-separate-binar.patch --]
[-- Type: text/x-patch, Size: 1949 bytes --]

From fe4bb20bbbff31ce1eb86afe8e81e8f0a3564877 Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Mon, 29 Jul 2013 08:43:14 -0400
Subject: [PATCH] util-linux: Update for swapoff being a separate binary

In older versions of util-linux, swapon and swapoff were the
same binary, and it did runtime detection.  But since v2.22
which is util-linux commit 6cf8d46ceefe9a7, they are separate
binaries.

This patch is necessary to make the util-linux version of
swapoff work at all - currently in OE swapoff = swapon, which
is clearly broken =)

Probably most OE consumers use the busybox swapoff and hence
this has gone unnoticed.

Signed-off-by: Colin Walters <walters@verbum.org>
---
 meta/recipes-core/util-linux/util-linux.inc |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index c783385..0e18567 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -116,7 +116,7 @@ do_install () {
 	mkdir -p ${D}${base_bindir}
 
         sbinprogs="agetty ctrlaltdel cfdisk vipw vigr"
-        sbinprogs_a="pivot_root hwclock mkswap mkfs.minix fsck.minix losetup swapon fdisk readprofile fsck blkid blockdev"
+        sbinprogs_a="pivot_root hwclock mkswap mkfs.minix fsck.minix losetup swapon swapoff fdisk readprofile fsck blkid blockdev"
         usrbinprogs_a="chfn chsh hexdump last logger mesg newgrp renice utmpdump wall setsid chrt flock getopt"
         binprogs_a="dmesg kill more umount mount login reset"
 
@@ -141,9 +141,6 @@ do_install () {
 	install -d ${D}${sysconfdir}/default/
 	echo 'MOUNTALL="-t nonfs,nosmbfs,noncpfs"' > ${D}${sysconfdir}/default/mountall
 
-	ln -sf swapon.${BPN}   ${D}${base_sbindir}/swapoff.${BPN}
-	rm -f ${D}${sbindir}/swapoff
-
 	rm -f ${D}${bindir}/chkdupexe
 }
 
-- 
1.7.1


                 reply	other threads:[~2013-07-29 17:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375120093.15230.63.camel@localhost \
    --to=walters@verbum.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox