From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [WIP][PATCH 17/20] librsvg: Fix dependencies for PACKAGECONFIG gdkpixbuf
Date: Fri, 30 Aug 2013 15:59:43 +0100 [thread overview]
Message-ID: <1377874783.1059.98.camel@ted> (raw)
In-Reply-To: <521F898F.1060209@linux.intel.com>
On Thu, 2013-08-29 at 10:49 -0700, Saul Wold wrote:
> On 08/29/2013 09:03 AM, Martin Jansa wrote:
> > * without gtk+ or gdk-pixbuf available it gets disabled even with --enable-pixbuf-loader
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> > meta/recipes-gnome/librsvg/librsvg_2.32.1.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > index 4818422..30846bf 100644
> > --- a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > +++ b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > @@ -29,7 +29,7 @@ PACKAGECONFIG ??= "croco gdkpixbuf"
> > # Support embedded CSS stylesheets (recommended upstream)
> > PACKAGECONFIG[croco] = "--with-croco,--without-croco,libcroco"
> > # gdk-pixbuf loader
> > -PACKAGECONFIG[gdkpixbuf] = "--enable-pixbuf-loader,--disable-pixbuf-loader"
> > +PACKAGECONFIG[gdkpixbuf] = "--enable-pixbuf-loader,--disable-pixbuf-loader,gtk+ gdk-pixbuf"
>
> I think this needs to be a target only PACKAGECONFIG, as it will try to
> depend on gtk+-native when building the librsvg-native.
Also do we really need gtk for the pixbuf loader? gtk2 theme engine
pulls in gtk+ elsewhere?
Cheers,
Richard
next prev parent reply other threads:[~2013-08-30 15:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 16:02 [WIP][PATCH 00/20] Deterministic dependencies II Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 01/20] gstreamer1.0-libav: Add PACKAGECONFIG for orc Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 02/20] libunique: Add PACKAGECONFIG for dbus Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 03/20] aspell: Add PACKAGECONFIG for curses Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 04/20] xf86-input-synaptics: Add dependency on libxtst Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 05/20] xdypinfo: Add dependency on libxcomposite Martin Jansa
2013-09-02 17:11 ` Burton, Ross
2013-09-03 18:05 ` Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 06/20] libmatchbox: Add PACKAGECONFIG for png Martin Jansa
2013-09-02 14:01 ` Burton, Ross
2013-09-02 14:02 ` Burton, Ross
2013-09-03 18:29 ` Martin Jansa
2013-09-03 18:46 ` Burton, Ross
2013-08-29 16:02 ` [WIP][PATCH 07/20] matchbox-wm: Add dependency on libxfixes and libxcursor Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 08/20] telepathy-mission-control: Add PACKAGECONFIG for upower and connectivity Martin Jansa
2013-09-02 17:10 ` Burton, Ross
2013-09-03 18:08 ` Martin Jansa
2013-09-03 18:51 ` Burton, Ross
2013-09-03 18:57 ` Burton, Ross
2013-08-29 16:02 ` [WIP][PATCH 09/20] tcl: Add dependency on zlib Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 10/20] weston: Add PACKAGECONFIG for poppler Martin Jansa
2013-08-29 16:02 ` [WIP][PATCH 11/20] wget: Add dependency on libpcre Martin Jansa
2013-09-20 23:23 ` Randy MacLeod
2013-09-21 0:27 ` Khem Raj
2013-08-29 16:02 ` [WIP][PATCH 12/20] x11vnc: Add PACKAGECONFIG for xfixes, xinerama, xrandr and xdamage Martin Jansa
2013-09-02 17:07 ` Burton, Ross
2013-08-29 16:03 ` [WIP][PATCH 13/20] guile: Add PACKAGECONFIG for readline Martin Jansa
2013-08-29 16:03 ` [WIP][PATCH 14/20] consolekit: Add patch to explicitly disable polkit when not enabled Martin Jansa
2013-08-29 16:03 ` [WIP][PATCH 15/20] glib-networking: Add PACKAGECONFIG for p11-kit Martin Jansa
2013-08-29 16:03 ` [WIP][PATCH 16/20] lame: Add dependency on ncurses Martin Jansa
2013-08-29 16:03 ` [WIP][PATCH 17/20] librsvg: Fix dependencies for PACKAGECONFIG gdkpixbuf Martin Jansa
2013-08-29 17:49 ` Saul Wold
2013-08-29 18:30 ` Martin Jansa
2013-08-30 14:59 ` Richard Purdie [this message]
2013-09-03 10:17 ` Burton, Ross
2013-08-29 16:03 ` [WIP][PATCH 18/20] subversion: Add dependency on file for libmagic Martin Jansa
2013-09-10 0:44 ` Jonathan Liu
2013-08-29 16:03 ` [WIP][PATCH 19/20] systemd: Add PACKAGECONFIG for cryptsetup Martin Jansa
2013-08-29 16:03 ` [WIP][PATCH 20/20] qemu: Add PACKAGECONFIG for nss, uuid, tls and curses Martin Jansa
2013-09-10 18:54 ` [WIP][PATCH 00/20] Deterministic dependencies II Martin Jansa
2013-10-05 12:16 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377874783.1059.98.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox