From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ross Burton <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] qemu: add recommend of kernel-modules for all qemu machines
Date: Wed, 04 Sep 2013 23:01:54 +0100 [thread overview]
Message-ID: <1378332114.1059.260.camel@ted> (raw)
In-Reply-To: <1378311722-17752-1-git-send-email-ross.burton@intel.com>
On Wed, 2013-09-04 at 17:22 +0100, Ross Burton wrote:
> Only qemumips was recommending kernel-modules which meant that the other qemu
> machines were missing some kernel modules, for example binfmt-misc.
>
> Move the recommends to qemu.inc so that all qemu machines pull in the kernel
> modules that have been built.
>
> [ YOCTO #4863 ]
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/conf/machine/include/qemu.inc | 2 ++
> meta/conf/machine/qemumips.conf | 2 --
> meta/conf/machine/qemumips64.conf | 2 --
> 3 files changed, 2 insertions(+), 4 deletions(-)
How many modules are built for the qemu machines? Are they all useful?
I'm just trying to get a feel for how much we're adding here and whether
this is the right thing to be doing...
Cheers,
Richard
>
> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
> index 545f8d1..7baf13e 100644
> --- a/meta/conf/machine/include/qemu.inc
> +++ b/meta/conf/machine/include/qemu.inc
> @@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
>
> # Provide the nfs server kernel module for all qemu images
> KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
> +
> +MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
> diff --git a/meta/conf/machine/qemumips.conf b/meta/conf/machine/qemumips.conf
> index ce1c419..89721a6 100644
> --- a/meta/conf/machine/qemumips.conf
> +++ b/meta/conf/machine/qemumips.conf
> @@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
> KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
>
> SERIAL_CONSOLE = "115200 ttyS0"
> -
> -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
> diff --git a/meta/conf/machine/qemumips64.conf b/meta/conf/machine/qemumips64.conf
> index b2c7998..7ba98cb 100644
> --- a/meta/conf/machine/qemumips64.conf
> +++ b/meta/conf/machine/qemumips64.conf
> @@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
> KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
>
> SERIAL_CONSOLE = "115200 ttyS0"
> -
> -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
next prev parent reply other threads:[~2013-09-04 22:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 16:22 [PATCH] qemu: add recommend of kernel-modules for all qemu machines Ross Burton
2013-09-04 22:01 ` Richard Purdie [this message]
2013-09-05 0:51 ` Bruce Ashfield
2013-09-05 7:11 ` Martin Jansa
2013-09-05 10:20 ` Burton, Ross
2013-09-05 10:45 ` Burton, Ross
2013-09-05 13:09 ` Stanacar, StefanX
2013-09-05 14:19 ` Burton, Ross
2013-09-05 14:39 ` Burton, Ross
2013-09-05 12:21 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378332114.1059.260.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox