From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: "dvhart@linux.intel.com" <dvhart@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH_V2] HOB: split live into iso and hddimg
Date: Thu, 05 Sep 2013 09:44:31 +0100 [thread overview]
Message-ID: <1378370671.32427.25.camel@ted> (raw)
In-Reply-To: <5227D283.6050606@linux.intel.com>
On Wed, 2013-09-04 at 17:38 -0700, Saul Wold wrote:
> Also the patch summary does not conform to your style, it should be
> image*: split live into iso and hddimg for hob
>
> tells us more that it's the image code, not hob code.
>
> See additional comment below.
>
> On 09/04/2013 09:10 AM, Saul Wold wrote:
> > On 09/04/2013 08:57 AM, Valentin Popa wrote:
> >> changes to split live into iso and hddimg without
> >> adding a new image type class.
> >>
> >
> > Will there be corresponding patches for the places that IMAGE_FSTYPES
> > use the "live" type?
> >
> > There may also be some doc's changes that are needed.
> >
> > Sau!
> >
> >> [YOCTO #3197]
> >> ---
> >> meta/classes/image.bbclass | 11 ++++++++++-
> >> meta/classes/image_types.bbclass | 11 +++++++----
> >> 2 files changed, 17 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> >> index ea59c36..3f76d80 100644
> >> --- a/meta/classes/image.bbclass
> >> +++ b/meta/classes/image.bbclass
> >> @@ -87,7 +87,16 @@ do_rootfs[depends] +=
> >> "makedevs-native:do_populate_sysroot virtual/fakeroot-nati
> >> do_rootfs[depends] +=
> >> "virtual/update-alternatives-native:do_populate_sysroot
> >> update-rc.d-native:do_populate_sysroot"
> >> do_rootfs[recrdeptask] += "do_packagedata"
> >>
> >> -IMAGE_TYPE_live = '${@base_contains("IMAGE_FSTYPES", "live", "live",
> >> "empty", d)}'
> >> +NOISO = '${@base_contains("IMAGE_FSTYPES", "iso", "0", "1", d)}'
> >> +NOHDD = '${@base_contains("IMAGE_FSTYPES", "hddimg", "0", "1", d)}'
> >> +
> >> +def build_live(d):
> >> + if d.getVar('NOISO', True) == "0" or d.getVar('NOHDD', True) == "0":
> >> + return "live"
> >> + else:
> >> + return "empty"
> >> +
> I think RP suggested a way to simplify this code.
Its not clear from this patch but I think NOISO and NOHDD are used as
triggers elsewhere in the code so this is probably reasonable.
Cheers,
Richard
next prev parent reply other threads:[~2013-09-05 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 15:57 [PATCH_V2] HOB: split live into iso and hddimg Valentin Popa
2013-09-04 16:10 ` Saul Wold
2013-09-05 0:38 ` Saul Wold
2013-09-05 8:44 ` Richard Purdie [this message]
2013-09-05 11:52 ` Valentin Popa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378370671.32427.25.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox