From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Cc: yue.tao@windriver.com
Subject: [PATCH] package_rpm.bbclass: Fix no_recommendations and package_exclude
Date: Thu, 5 Sep 2013 18:48:42 -0500 [thread overview]
Message-ID: <1378424922-24009-1-git-send-email-mark.hatle@windriver.com> (raw)
When the code was refactored to address review comments, the wrong version
was sent to the community. Replace the $1 with ${target_rootfs}
Fix identified by: Yue Tao <yue.tao@windriver.com>
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
meta/classes/package_rpm.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
index cc77c5e..8ab42c4 100644
--- a/meta/classes/package_rpm.bbclass
+++ b/meta/classes/package_rpm.bbclass
@@ -360,10 +360,10 @@ EOF
package_write_smart_config ${target_rootfs}
# Do the following configurations here, to avoid them being saved for field upgrade
if [ "x${NO_RECOMMENDATIONS}" = "x1" ]; then
- smart --data-dir=$1/var/lib/smart config --set ignore-all-recommends=1
+ smart --data-dir=${target_rootfs}/var/lib/smart config --set ignore-all-recommends=1
fi
for i in ${PACKAGE_EXCLUDE}; do
- smart --data-dir=$1/var/lib/smart flag --set exclude-packages $i
+ smart --data-dir=${target_rootfs}/var/lib/smart flag --set exclude-packages $i
done
# Optional debugging
--
1.8.1.2.545.g2f19ada
reply other threads:[~2013-09-05 23:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378424922-24009-1-git-send-email-mark.hatle@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yue.tao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox