From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id 71F35610F7 for ; Tue, 24 Sep 2013 08:25:28 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r8O8eGCb002534; Tue, 24 Sep 2013 09:40:16 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id B6KVy320B_va; Tue, 24 Sep 2013 09:40:15 +0100 (BST) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r8O8eB3n002527 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Tue, 24 Sep 2013 09:40:12 +0100 Message-ID: <1380011114.18603.270.camel@ted> From: Richard Purdie To: David Nystrom Date: Tue, 24 Sep 2013 09:25:14 +0100 In-Reply-To: <1379970871.18603.265.camel@ted> References: <1379954041-5575-1-git-send-email-david.nystrom@enea.com> <1379954041-5575-2-git-send-email-david.nystrom@enea.com> <5240820E.5020407@windriver.com> <1379970871.18603.265.camel@ted> X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] shadow: Create recipe nativesdk-shadow X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2013 08:25:28 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2013-09-23 at 22:14 +0100, Richard Purdie wrote: > On Mon, 2013-09-23 at 21:01 +0200, David Nystrom wrote: > > > > On Sep 23, 2013 8:01 PM, "Mark Hatle" > > wrote: > > > > > > This looks to be the same as the 'native' package, but I don't think > > you can just add a BBCLASSEXTEND = "nativesdk" > > > > It mostly is and I cant, your right. > > Why not? Just the SRC_URI or other issues? > > > > Perhaps (in 1.6) someone should look at merging the three back > > together. > > > > Agree, the merged recipe will also get a bit messy, but probably > > easier to maintain than in its current state. > > > > > If this is the same as the native version, I'd suggest adding a > > comment stating as much so we can hopefully keep them in sync. > > > > Will do, will return with v2 > > > Well, I'm not happy with the idea of duplicating all this code. > shadow-native shouldn't exist and this makes things worse. With a few > minutes, I could write this patch: > > http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/t2&id=0730423fcda165a12112182b093d2f6df2f9c5eb > > which at least makes the situation a bit less ugly. I guess I did spend > years doing these kinds of patches back when we had 50 versions of > everything and BBCLASSEXTEND didn't yet exist. With a few more minutes > perhaps I can get rid of the separate -native, now the differences are > clear. meld is a nice too for this kind of work btw. Better still, a conversion to BBCLASSEXTEND: http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/t2&id=142d11b9b61bf18567cdb0527b7e63683c5afa1a Cheers, Richard