From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alex DAMIAN <alexandru.damian@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/3] package.bbclass: trigger event when collecting package info
Date: Tue, 24 Sep 2013 17:44:06 +0100 [thread overview]
Message-ID: <1380041046.18603.298.camel@ted> (raw)
In-Reply-To: <3145da4c2b158fd0e2684b66cd68dd769a1c94de.1380040307.git.alexandru.damian@intel.com>
On Tue, 2013-09-24 at 17:36 +0100, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>
> Adding an event that contains the package details,
> which is triggered when the emit_pkgdata runs.
> This is used to collect package information in the UI clients.
>
> Slight rewrite of the file-writing section as to make
> the code easier to maintain.
>
> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
> ---
> meta/classes/package.bbclass | 41 +++++++++++++----------------------------
> 1 file changed, 13 insertions(+), 28 deletions(-)
Simply put, this isn't going in and it isn't right.
If you want to do this, please do this in a different class file which
hooks into the packaging code and generates the event needed, preferably
with one event rather than two.
The class can then be inherited when webhob is enabled (and removed from
influencing the sstate checksums).
Cheers,
Richard
next prev parent reply other threads:[~2013-09-24 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 16:35 [PATCH 0/3] metadata additions for Webhob Alex DAMIAN
2013-09-24 16:36 ` [PATCH 1/3] documentation.conf: update contents Alex DAMIAN
2013-09-24 16:36 ` [PATCH 2/3] package.bbclass: trigger event when collecting package info Alex DAMIAN
2013-09-24 16:44 ` Richard Purdie [this message]
2013-09-24 16:44 ` Otavio Salvador
2013-09-24 16:36 ` [PATCH 3/3] package: fire an event with file sizes Alex DAMIAN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380041046.18603.298.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=alexandru.damian@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox