From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] wic: add fakeroot to the populate-extfs step
Date: Wed, 16 Oct 2013 16:36:50 +0100 [thread overview]
Message-ID: <1381937810.29912.487.camel@ted> (raw)
In-Reply-To: <1381936247.23041.119.camel@dvhart-mobl4.amr.corp.intel.com>
On Wed, 2013-10-16 at 08:10 -0700, Darren Hart wrote:
> On Wed, 2013-10-16 at 13:09 +0100, Richard Purdie wrote:
> > On Wed, 2013-10-16 at 00:14 -0500, Tom Zanussi wrote:
> > > Without this, files in the generated filesystem pick up the wrong
> > > ownership.
> > >
> > > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > > ---
> > > scripts/lib/mic/kickstart/custom_commands/partition.py | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/scripts/lib/mic/kickstart/custom_commands/partition.py b/scripts/lib/mic/kickstart/custom_commands/partition.py
> > > index 302cace..309abee 100644
> > > --- a/scripts/lib/mic/kickstart/custom_commands/partition.py
> > > +++ b/scripts/lib/mic/kickstart/custom_commands/partition.py
> > > @@ -216,7 +216,7 @@ class Wic_PartData(Mic_PartData):
> > > """
> > > Prepare content for an ext2/3/4 rootfs partition.
> > > """
> > > - populate_script = "%s/usr/bin/populate-extfs.sh" % native_sysroot
> > > + populate_script = "fakeroot %s/usr/bin/populate-extfs.sh" % native_sysroot
> > > image_extra_space = 10240
> > >
> > > image_rootfs = rootfs_dir
> >
> > We don't use fakeroot, please use pseudo. If pseudo doesn't work, we
> > need to figure out why and fix it.
> >
>
> Ultimately this needs to work independently from bitbake. Is that
> practical if we use pseudo here?
pseudo is an independent project and you can build and use it outside of
bitbake no problems at all. My worry is we didn't adopt fakeroot for
many good reasons. I don't want "fixing fakeroot" to suddenly appear on
the agenda. We did that and its called pseudo.
Cheers,
Richard
next prev parent reply other threads:[~2013-10-16 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 5:14 [PATCH 0/3] a few wic fixes Tom Zanussi
2013-10-16 5:14 ` [PATCH 1/3] wic: check for build artifacts Tom Zanussi
2013-10-16 5:14 ` [PATCH 2/3] wic: check passed-in build artifact directories Tom Zanussi
2013-10-16 5:14 ` [PATCH 3/3] wic: add fakeroot to the populate-extfs step Tom Zanussi
2013-10-16 12:09 ` Richard Purdie
2013-10-16 15:10 ` Darren Hart
2013-10-16 15:36 ` Richard Purdie [this message]
2013-10-16 16:05 ` Darren Hart
2013-10-16 16:32 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381937810.29912.487.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox