Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Ming Liu <ming.liu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2 2/2] screen: add pkg_postinst to register entry to /etc/shells
Date: Thu, 17 Oct 2013 11:11:51 +0100	[thread overview]
Message-ID: <1382004711.484.47.camel@phil-desktop.brightsign> (raw)
In-Reply-To: <1382004192-12678-2-git-send-email-ming.liu@windriver.com>

On Thu, 2013-10-17 at 18:03 +0800, Ming Liu wrote:
> +pkg_postinst_${PN} () {
> +	touch $D${sysconfdir}/shells
> +	grep -q "${bindir}/screen" $D${sysconfdir}/shells || echo ${bindir}/screen >> $D${sysconfdir}/shells
> +}

Is that "touch" really desirable?  It seems as though screen ought not
really to be creating /etc/shells if it isn't there already, and
probably ought not to be updating the timestamp if it isn't actually
changing the file either.

p.



  reply	other threads:[~2013-10-17 10:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 10:03 [PATCH V2 1/2] base-files: move shells generating process to pkg_postinst Ming Liu
2013-10-17 10:03 ` [PATCH V2 2/2] screen: add pkg_postinst to register entry to /etc/shells Ming Liu
2013-10-17 10:11   ` Phil Blundell [this message]
2013-10-17 10:28     ` Ming Liu
2013-10-17 10:53       ` Phil Blundell
2013-10-17 11:06         ` Ming Liu
2013-10-17 10:33   ` Martin Jansa
2013-10-17 10:44     ` Ming Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382004711.484.47.camel@phil-desktop.brightsign \
    --to=pb@pbcl.net \
    --cc=ming.liu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox