Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "David Nyström" <david.c.nystrom@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 10/11] nativesdk-packagegroup-sdk-host: Add new DISTRO_FEATURE, sdk-pms
Date: Fri, 18 Oct 2013 15:54:42 +0100	[thread overview]
Message-ID: <1382108082.29912.550.camel@ted> (raw)
In-Reply-To: <1382018386-25389-11-git-send-email-david.nystrom@enea.com>

On Thu, 2013-10-17 at 15:59 +0200, David Nyström wrote:
> Added a new distro feature called sdk-pms, since smartpm rdepends
> on the python runtime.
> This to avoid bloating the SDK tarball for those who does not
> want it.
> 
> Signed-off-by: David Nyström <david.nystrom@enea.com>
> ---
>  meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> index e298ff4..1f45c4c 100644
> --- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> +++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> @@ -16,7 +16,8 @@ RDEPENDS_${PN} = "\
>      nativesdk-qemu-helper \
>      nativesdk-pseudo \
>      nativesdk-unfs-server \
> -    nativesdk-opkg \
> +    ${@base_contains('DISTRO_FEATURES', 'sdk-pms', 'nativesdk-opkg','', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'sdk-pms', 'nativesdk-smartpm','', d)} \
>      nativesdk-libtool \
>      nativesdk-autoconf \
>      nativesdk-automake \

I think we need to keep a list of DISTRO_FEATURES somewhere along with a
definition about what the feature is supposed to do. For example this is
clearly about power management, right? :)

Along with this addition could you start a list somewhere documenting
this?

Cheers,

Richard




  reply	other threads:[~2013-10-18 14:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 13:59 [PATCH 00/11] RPM PMS in SDK tarball David Nyström
2013-10-17 13:59 ` [PATCH 01/11] popt: Add nativesdk in BBCLASSEXTEND David Nyström
2013-10-17 13:59 ` [PATCH 02/11] icu: " David Nyström
2013-10-17 13:59 ` [PATCH 03/11] beecrypt: " David Nyström
2013-10-17 13:59 ` [PATCH 04/11] attr: " David Nyström
2013-10-17 13:59 ` [PATCH 05/11] acl: " David Nyström
2013-10-17 13:59 ` [PATCH 06/11] rpmresolve: " David Nyström
2013-10-17 13:59 ` [PATCH 07/11] smartpm: " David Nyström
2013-10-17 13:59 ` [PATCH 08/11] ossp-uuid: " David Nyström
2013-10-17 13:59 ` [PATCH 09/11] file: " David Nyström
2013-10-17 13:59 ` [PATCH 10/11] nativesdk-packagegroup-sdk-host: Add new DISTRO_FEATURE, sdk-pms David Nyström
2013-10-18 14:54   ` Richard Purdie [this message]
2013-10-18 18:53     ` David Nystrom
2013-10-17 13:59 ` [PATCH 11/11] rpm: Add nativesdk in BBCLASSEXTEND David Nyström
2013-10-17 14:31   ` Mark Hatle
2013-10-17 16:00     ` David Nystrom
2013-10-18 10:27   ` [PATCHv2] rpm: Add nativesdk to BBCLASSEXTEND David Nyström
2013-10-21 18:03     ` David Nystrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382108082.29912.550.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=david.c.nystrom@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox