Openembedded Core Discussions
 help / color / mirror / Atom feed
From: <qiang.chen@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH] nfsserver restart should kill and recreate nfsd kernel threads
Date: Tue, 22 Oct 2013 11:19:00 +0800	[thread overview]
Message-ID: <1382411940-1430-1-git-send-email-qiang.chen@windriver.com> (raw)

From: Qiang Chen <qiang.chen@windriver.com>

nfsserver restart without killing kernel threads worked when portmap
was the rpc publishing process and portmap was restarted.
When rpcbind replaces portmap, nfsserver restart in this way does not
work after an rpcbind restart.

Steps to reproduce:
1). Make ext3 filesystem image on local host.
cd /root
dd if=/dev/zero of=test bs=1024K count=50
mkfs.ext3 -F test

2). runqemu qemux86-64
mkdir /mnt/wrtest
mount -t ext3 -o loop test /mnt/wrtest
echo "/mnt/wrtest *(sync,rw,no_subtree_check,no_root_squash)" > /etc/exports
/etc/init.d/rpcbind restart
/etc/init.d/nfsserver restart
showmount -e localhost
mkdir wrtest
mount -t nfs localhost:/mnt/wrtest wrtest

mount: mounting localhost:/mnt/wrtest on wrtest failed: Connection refused

Modifying the nfsserver script to kill and restart kernel threads on
restart makes the problem go away and is consistent with current
RHEL/SUSE and Ubuntu/Debian mechanisms of handling the nfs server.

Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
Signed-off-by: Qiang Chen <qiang.chen@windriver.com>
---
 .../nfs-utils/nfs-utils/nfsserver                  |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver b/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
index 8ee8d0b..d7cf6e0 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
@@ -161,14 +161,9 @@ status)
 	[ $RETVAL -eq 0 ] && exit $rval
 	exit $RETVAL;;
 reload)	test -r /etc/exports && exportfs -r;;
-restart)exportfs -ua
-	stop_mountd
-	stop_statd
-	# restart does not restart the kernel threads,
-	# only the user mode processes
-	start_mountd
-	start_statd
-	test -r /etc/exports && exportfs -a;;
+restart)
+	$0 stop
+	$0 start;;
 *)	echo "Usage: $0 {start|stop|status|reload|restart}"
 	exit 1;;
 esac
-- 
1.7.9.5



             reply	other threads:[~2013-10-22  3:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22  3:19 qiang.chen [this message]
2013-10-24 21:13 ` [PATCH] nfsserver restart should kill and recreate nfsd kernel threads Saul Wold
2013-10-25  6:33   ` Qiang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382411940-1430-1-git-send-email-qiang.chen@windriver.com \
    --to=qiang.chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox