From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: blloyd <blloyd@familyhonor.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] Allow passthrough of important placement variables when using devshell
Date: Fri, 01 Nov 2013 11:04:55 +0000 [thread overview]
Message-ID: <1383303895.25877.142.camel@ted> (raw)
In-Reply-To: <eec32fc87fea48dfecfb8af9e26956efaab59558.1383206227.git.blloyd@familyhonor.net>
On Thu, 2013-10-31 at 03:02 -0500, blloyd wrote:
> The environment is very well sanitized when using the shell. However, when using devshell developers are typically interested in sources and build artifacts. The variables B S and D control this but are cleaned from the environment when a shell is started. Add a new variable to allow additional variables to be kept for a developer shell and set it to "B S D" by default. The implementation allows variables for developer convenience and verification while not changing shells used for compile tasks.
>
> Signed-off-by: blloyd <blloyd@familyhonor.net>
> ---
> meta/classes/devshell.bbclass | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Also, the summary of the commit message should start "devshell: " and
you should fold in the whitespace fix patch.
Cheers,
Richard
next prev parent reply other threads:[~2013-11-01 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 8:02 [PATCH 0/2] devshell should make finding source and build artifacts easy blloyd
2013-10-31 8:02 ` [PATCH 1/2] Allow passthrough of important placement variables when using devshell blloyd
2013-11-01 11:04 ` Richard Purdie
2013-11-01 11:04 ` Richard Purdie [this message]
2013-10-31 8:02 ` [PATCH 2/2] Removed trailing whitespace added with last commit blloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383303895.25877.142.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=blloyd@familyhonor.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox